2023-05-07 20:29:04

by Matti Lehtimäki

Subject: [PATCH 4/6] ARM: dts: msm8226: Add qfprom node

Add missing QFPROM definition for MSM8226 SoC.

Signed-off-by: Matti Lehtimäki <[email protected]>
---
arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
index c373081bc21b..c34b8f3139ae 100644
--- a/arch/arm/boot/dts/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
@@ -505,6 +505,13 @@ restart@fc4ab000 {
reg = <0xfc4ab000 0x4>;
};

+ qfprom: qfprom@fc4bc000 {
+ compatible = "qcom,msm8226-qfprom", "qcom,qfprom";
+ reg = <0xfc4bc000 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+
spmi_bus: spmi@fc4cf000 {
compatible = "qcom,spmi-pmic-arb";
reg-names = "core", "intr", "cnfg";
--
2.34.1

2023-05-07 20:45:44

by Luca Weiss

Subject: Re: [PATCH 4/6] ARM: dts: msm8226: Add qfprom node

On Sonntag, 7. Mai 2023 22:12:22 CEST Matti Lehtim?ki wrote:
> Add missing QFPROM definition for MSM8226 SoC.
>
> Signed-off-by: Matti Lehtim?ki <[email protected]>

Reviewed-by: Luca Weiss <[email protected]>

> ---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi
> b/arch/arm/boot/dts/qcom-msm8226.dtsi index c373081bc21b..c34b8f3139ae
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -505,6 +505,13 @@ restart@fc4ab000 {
> reg = <0xfc4ab000 0x4>;
> };
>
> + qfprom: qfprom@fc4bc000 {
> + compatible = "qcom,msm8226-qfprom",
"qcom,qfprom";
> + reg = <0xfc4bc000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> spmi_bus: spmi@fc4cf000 {
> compatible = "qcom,spmi-pmic-arb";
> reg-names = "core", "intr", "cnfg";

2023-05-07 21:20:00

by Dmitry Baryshkov

Subject: Re: [PATCH 4/6] ARM: dts: msm8226: Add qfprom node

On 07/05/2023 23:12, Matti Lehtimäki wrote:
> Add missing QFPROM definition for MSM8226 SoC.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-05-10 14:16:33

by Krzysztof Kozlowski

Subject: Re: [PATCH 4/6] ARM: dts: msm8226: Add qfprom node

On 07/05/2023 22:12, Matti Lehtimäki wrote:
> Add missing QFPROM definition for MSM8226 SoC.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
> arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index c373081bc21b..c34b8f3139ae 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -505,6 +505,13 @@ restart@fc4ab000 {
> reg = <0xfc4ab000 0x4>;
> };
>
> + qfprom: qfprom@fc4bc000 {

We usually call this efuse@

qfprom is Qualcomm specific.

Best regards,
Krzysztof

2023-05-10 14:29:30

by Dmitry Baryshkov

Subject: Re: [PATCH 4/6] ARM: dts: msm8226: Add qfprom node

On Wed, 10 May 2023 at 16:59, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 07/05/2023 22:12, Matti Lehtimäki wrote:
> > Add missing QFPROM definition for MSM8226 SoC.
> >
> > Signed-off-by: Matti Lehtimäki <[email protected]>
> > ---
> > arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> > index c373081bc21b..c34b8f3139ae 100644
> > --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> > +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> > @@ -505,6 +505,13 @@ restart@fc4ab000 {
> > reg = <0xfc4ab000 0x4>;
> > };
> >
> > + qfprom: qfprom@fc4bc000 {
>
> We usually call this efuse@

We have 5 efuse@ and 14 qfprom@ (next/master). But that probably means
that we should rename existing qfprom@ to efuse@.

>
> qfprom is Qualcomm specific.
>
> Best regards,
> Krzysztof
>


--
With best wishes
Dmitry