2023-05-08 04:13:11

by Lukas Bulwahn

Subject: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
no effect and any further purpose.

Remove the obsolete config S3C64XX_SETUP_IDE.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
arch/arm/mach-s3c/Kconfig.s3c64xx | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx
index 01a7a8eec6e8..8f40af063ad6 100644
--- a/arch/arm/mach-s3c/Kconfig.s3c64xx
+++ b/arch/arm/mach-s3c/Kconfig.s3c64xx
@@ -69,11 +69,6 @@ config S3C64XX_SETUP_I2C1
help
Common setup code for i2c bus 1.

-config S3C64XX_SETUP_IDE
- bool
- help
- Common setup code for S3C64XX IDE.
-
config S3C64XX_SETUP_FB_24BPP
bool
help
@@ -110,7 +105,6 @@ config MACH_WLF_CRAGG_6410
select S3C64XX_DEV_SPI0
select S3C64XX_SETUP_FB_24BPP
select S3C64XX_SETUP_I2C1
- select S3C64XX_SETUP_IDE
select S3C64XX_SETUP_KEYPAD
select S3C64XX_SETUP_SDHCI
select S3C64XX_SETUP_SPI
--
2.17.1

2023-05-08 05:49:11

by Arnd Bergmann

Subject: Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

On Mon, May 8, 2023, at 06:04, Lukas Bulwahn wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
>
> Remove the obsolete config S3C64XX_SETUP_IDE.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>

Indeed, this was only used on the smdk64xx board file,
so the file was removed along with the deletion of the board,
but I forgot to remove the Kconfig option.

Acked-by: Arnd Bergmann <[email protected]>

2023-05-08 09:31:10

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE

On Mon, 08 May 2023 06:04:33 +0200, Lukas Bulwahn wrote:
> Commit 0d297df03890 ("ARM: s3c: simplify platform code") removes the line
> in Makefile.s3c64xx to configure the inclusion of setup-ide-s3c64xx.c,
> with CONFIG_S3C64XX_SETUP_IDE. So, since then, config S3C64XX_SETUP_IDE has
> no effect and any further purpose.
>
> Remove the obsolete config S3C64XX_SETUP_IDE.
>
> [...]

Applied, thanks!

[1/1] ARM: s3c: remove obsolete config S3C64XX_SETUP_IDE
https://git.kernel.org/krzk/linux/c/9d2edccb154bd98baf7f1e21d23f799e4f5e8359

Best regards,
--
Krzysztof Kozlowski <[email protected]>