2023-05-08 04:43:39

by Lukas Bulwahn

Subject: [PATCH] s390/Kconfig: remove obsolete configs SCHED_{BOOK,DRAWER}

Commit f1045056c726 ("topology/sysfs: rework book and drawer topology
ifdefery") activates the book and drawer topology, previously activated by
CONFIG_SCHED_{BOOK,DRAWER}, dependent on the existence of certain macro
definitions. Hence, since then, CONFIG_SCHED_{BOOK,DRAWER} have no effect
and any further purpose.

Remove the obsolete configs SCHED_{BOOK,DRAWER}.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
arch/s390/Kconfig | 8 --------
1 file changed, 8 deletions(-)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 548b5b587003..1627c7f841d3 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -468,19 +468,11 @@ config SCHED_SMT
config SCHED_MC
def_bool n

-config SCHED_BOOK
- def_bool n
-
-config SCHED_DRAWER
- def_bool n
-
config SCHED_TOPOLOGY
def_bool y
prompt "Topology scheduler support"
select SCHED_SMT
select SCHED_MC
- select SCHED_BOOK
- select SCHED_DRAWER
help
Topology scheduler support improves the CPU scheduler's decision
making when dealing with machines that have multi-threading,
--
2.17.1

2023-05-12 15:18:40

by Alexander Gordeev

Subject: Re: [PATCH] s390/Kconfig: remove obsolete configs SCHED_{BOOK,DRAWER}

On Mon, May 08, 2023 at 06:09:16AM +0200, Lukas Bulwahn wrote:
> Commit f1045056c726 ("topology/sysfs: rework book and drawer topology
> ifdefery") activates the book and drawer topology, previously activated by
> CONFIG_SCHED_{BOOK,DRAWER}, dependent on the existence of certain macro
> definitions. Hence, since then, CONFIG_SCHED_{BOOK,DRAWER} have no effect
> and any further purpose.
>
> Remove the obsolete configs SCHED_{BOOK,DRAWER}.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> arch/s390/Kconfig | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 548b5b587003..1627c7f841d3 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -468,19 +468,11 @@ config SCHED_SMT
> config SCHED_MC
> def_bool n
>
> -config SCHED_BOOK
> - def_bool n
> -
> -config SCHED_DRAWER
> - def_bool n
> -
> config SCHED_TOPOLOGY
> def_bool y
> prompt "Topology scheduler support"
> select SCHED_SMT
> select SCHED_MC
> - select SCHED_BOOK
> - select SCHED_DRAWER
> help
> Topology scheduler support improves the CPU scheduler's decision
> making when dealing with machines that have multi-threading,

Applied, thanks!