2023-05-09 07:08:08

by Ed Tsai (蔡宗軒)

[permalink] [raw]
Subject: [PATCH 0/2] block: improve the share tag set performance

The tag allocation is limited by the number of active queues and a
queue is marked as inactive by the queue timeout worker after up to 30Hz
by default.

UFS devices have multiple logical units, and they can limit the depth of
data LUNs by the fair tag sharing algorithm. Make the fair tag sharing
configurable and improve the performance for UFS devices.

See also https://lore.kernel.org/all/[email protected]

Ed Tsai (2):
block: make the fair sharing of tag configurable
ufs: don't use the fair tag sharings

block/blk-mq-debugfs.c | 1 +
block/blk-mq-tag.c | 1 +
block/blk-mq.c | 3 ++-
drivers/ufs/core/ufshcd.c | 3 +++
include/linux/blkdev.h | 6 +++++-
5 files changed, 12 insertions(+), 2 deletions(-)

--
2.18.0


2023-05-10 23:08:06

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH 0/2] block: improve the share tag set performance

On 5/8/23 23:52, Ed Tsai wrote:
> The tag allocation is limited by the number of active queues and a
> queue is marked as inactive by the queue timeout worker after up to 30Hz
> by default.
>
> UFS devices have multiple logical units, and they can limit the depth of
> data LUNs by the fair tag sharing algorithm. Make the fair tag sharing
> configurable and improve the performance for UFS devices.
>
> See also https://lore.kernel.org/all/[email protected]

Hi Jens,

This patch series is slightly more complicated than the patch that I
posted in January. Do you prefer the approach of this patch series or
rather the approach of the patch that I posted in January?

Thank you,

Bart.