2023-05-09 11:24:23

by Himanshu Bhavani

[permalink] [raw]
Subject: [PATCH] dt-bindings: arm: fsl: Enumerate Emtop SOM

Add entries to the list of imx8mm boards denoting
the Emtop SOM from Emtop.

Signed-off-by: Himanshu Bhavani <[email protected]>

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 442ce8f4d675..06eb2c790f90 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -884,6 +884,7 @@ properties:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
- boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
- dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
+ - emtop,imx8mm-emtop # i.MX8MM Emtop SoM
- emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
--
2.25.1


2023-05-09 13:20:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: arm: fsl: Enumerate Emtop SOM

On 09/05/2023 13:19, Himanshu Bhavani wrote:
> Add entries to the list of imx8mm boards denoting
> the Emtop SOM from Emtop.
>
> Signed-off-by: Himanshu Bhavani <[email protected]>
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..06eb2c790f90 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -884,6 +884,7 @@ properties:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
> - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
> + - emtop,imx8mm-emtop # i.MX8MM Emtop SoM

So the name of the board is emtop? Are you sure?

Anyway, organize and version your patches. Your work, which now I found,
must be one patchset. We have it very nicely documented

https://elixir.bootlin.com/linux/v5.19-rc5/source/Documentation/process/submitting-patches.rst
https://elixir.bootlin.com/linux/v5.19-rc5/source/Documentation/process/5.Posting.rst

Best regards,
Krzysztof