2023-05-10 11:49:42

by Himanshu Bhavani

[permalink] [raw]
Subject: [PATCH v4 0/3] arm64: dts: Add initial support for Emtop SOM IMX8MM

Add the initial device tree support for Emtop SOM based om IMX8MM.

Change in v2:
- in patch 1/3:
- Update dtb add order in Makefile
- Update proper prefix/name in dts
- Removed stray blank line
- Add pinctrl-names

- in patch 2/3:
- Update bindings

Changes in v3:
- in patch 1/3:
- Removed dead code
- Fixed style and indentations

- in patch 3/3:
- Update vendor prefix

Changes in v4:
- in patch 2/3
- Update SoM Name

- in patch 3/3:
- Add Acked-by

Himanshu Bhavani (3):
arm64: dts: Add device tree for the Emtop SOM IMX8MM
dt-bindings: arm: fsl: Enumerate Emtop SOM
dt-bindings: vendor-prefixes: Add Emtop

.../devicetree/bindings/arm/fsl.yaml | 1 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../arm64/boot/dts/freescale/imx8mm-emtop.dts | 261 ++++++++++++++++++
4 files changed, 265 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emtop.dts

--
2.25.1



2023-05-10 11:52:10

by Himanshu Bhavani

[permalink] [raw]
Subject: [PATCH v4 3/3] dt-bindings: vendor-prefixes: Add Emtop

Add an entry for Emtop to vendor-prefixes.yaml

Signed-off-by: Himanshu Bhavani <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index ed64e06ecca4..e6e3c99f6ac1 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -412,6 +412,8 @@ patternProperties:
description: EM Microelectronic
"^empire-electronix,.*":
description: Empire Electronix
+ "^emtop,.*":
+ description: Emtop
"^emtrion,.*":
description: emtrion GmbH
"^enclustra,.*":
--
2.25.1


2023-05-10 11:52:34

by Himanshu Bhavani

[permalink] [raw]
Subject: [PATCH v4 2/3] dt-bindings: arm: fsl: Enumerate Emtop SOM

Add entries to the list of imx8mm boards denoting
the Emtop SOM from Emtop.

Signed-off-by: Himanshu Bhavani <[email protected]>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 442ce8f4d675..06eb2c790f90 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -884,6 +884,7 @@ properties:
- beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
- boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
- dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
+ - emtop,imx8mm-emtop # i.MX8MM Emtop SOM-IMX8MMLPD4 SoM
- emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
- fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
- fsl,imx8mm-evk # i.MX8MM EVK Board
--
2.25.1


2023-05-10 13:17:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 2/3] dt-bindings: arm: fsl: Enumerate Emtop SOM

On 10/05/2023 13:23, Himanshu Bhavani wrote:
> Add entries to the list of imx8mm boards denoting
> the Emtop SOM from Emtop.
>
> Signed-off-by: Himanshu Bhavani <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 442ce8f4d675..06eb2c790f90 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -884,6 +884,7 @@ properties:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board
> - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
> + - emtop,imx8mm-emtop # i.MX8MM Emtop SOM-IMX8MMLPD4 SoM

No real improvements. Still not change in compatible - neither naming
nor additional compatible.

Instead of adding some random changes, please describe in commit msg
what is this exactly and then use compatibles matching it.

You already got two times the same comment that board called "emtop" so
the same as vendor "emtop" looks wrong. You never responded to these
comments. Don't ignore feedbacks, but either respond or implement them.

Best regards,
Krzysztof