2023-05-10 14:35:32

by Peter De Schrijver

[permalink] [raw]
Subject: [PATCH v3 0/6] firmware: tegra: Add MRQ support for Tegra264.

In Tegra264 the carveouts (GSCs) used to communicate between BPMP and
CPU-NS may reside in DRAM. The location will be signalled using reserved
memory node in DT. Additionally some minor updates to the HSP driver are
done to support the new chip.

Peter De Schrijver (4):
dt-bindings: mailbox: tegra: Document Tegra264 HSP
dt-bindings: Add bindings to support DRAM MRQ GSCs
dt-bindings: memory-region property for tegra186-bpmp
firmware: tegra: bpmp: Add support for DRAM MRQ GSCs

Stefan Kristiansson (2):
mailbox: tegra: add support for Tegra264
soc: tegra: fuse: add support for Tegra264

Changes in v2:

- Added signoff messages
- Updated bindings to support DRAM MRQ GSCs
- Split out memory-region property for tegra186-bpmp
- Addressed sparse errors in bpmp-tegra186.c

Changes in v3:

- Add #address-cells = <2> and #size-cells = <2> to
nvidia,tegra264-bpmp-shmem binding example.

.../firmware/nvidia,tegra186-bpmp.yaml | 37 ++-
.../bindings/mailbox/nvidia,tegra186-hsp.yaml | 1 +
.../nvidia,tegra264-bpmp-shmem.yaml | 47 ++++
drivers/firmware/tegra/bpmp-tegra186.c | 214 ++++++++++++------
drivers/firmware/tegra/bpmp.c | 4 +-
drivers/mailbox/tegra-hsp.c | 16 +-
drivers/soc/tegra/fuse/tegra-apbmisc.c | 3 +-
include/soc/tegra/fuse.h | 3 +-
8 files changed, 253 insertions(+), 72 deletions(-)
create mode 100644 Documentation/devicetree/bindings/reserved-memory/nvidia,tegra264-bpmp-shmem.yaml

--
2.34.1



2023-05-10 15:02:18

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v3 0/6] firmware: tegra: Add MRQ support for Tegra264.

On Wed, May 10, 2023 at 05:22:42PM +0300, Peter De Schrijver wrote:
> In Tegra264 the carveouts (GSCs) used to communicate between BPMP and
> CPU-NS may reside in DRAM. The location will be signalled using reserved
> memory node in DT. Additionally some minor updates to the HSP driver are
> done to support the new chip.

I was still reviewing v2 when you sent this out. Obviously none of those
comments have now been addressed, so we'll need v4. Generally, try to
give people a bit more time to review patches before sending new
versions even if you've got early feedback from the various bots. You
can of course already integrate fixes for issues pointed out, but there
is no need to rush one version after the other at this point in the
review cycle.

Thierry


Attachments:
(No filename) (779.00 B)
signature.asc (849.00 B)
Download all attachments