2023-05-11 14:12:28

by jerome Neanne

Subject: [PATCH v2 2/2] mfd: tps65219: Add gpio cell instance

tps65219 PMIC GPIOs are exposed in a standard way:
gpiodetect
gpiochip0 [tps65219-gpio] (3 lines)

Co-developed-by: Jonathan Cormier <[email protected]>
Signed-off-by: Jonathan Cormier <[email protected]>
Signed-off-by: Jerome Neanne <[email protected]>
---
drivers/mfd/tps65219.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
index 0e402fda206b..e1d090ba4258 100644
--- a/drivers/mfd/tps65219.c
+++ b/drivers/mfd/tps65219.c
@@ -106,7 +106,7 @@ static const struct mfd_cell tps65219_cells[] = {
.resources = tps65219_regulator_resources,
.num_resources = ARRAY_SIZE(tps65219_regulator_resources),
},
- { .name = "tps65219-gpios", },
+ { .name = "tps65219-gpio", },
};

static const struct mfd_cell tps65219_pwrbutton_cell = {

--
2.34.1

2023-05-11 21:08:09

by Linus Walleij

Subject: Re: [PATCH v2 2/2] mfd: tps65219: Add gpio cell instance

On Thu, May 11, 2023 at 4:09 PM Jerome Neanne <[email protected]> wrote:

> tps65219 PMIC GPIOs are exposed in a standard way:
> gpiodetect
> gpiochip0 [tps65219-gpio] (3 lines)

Write something in the commit message about that the cell
has the wrong name, because all you do is change it from
plural to singular.

> Co-developed-by: Jonathan Cormier <[email protected]>
> Signed-off-by: Jonathan Cormier <[email protected]>
> Signed-off-by: Jerome Neanne <[email protected]>

With that:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij