2023-05-17 07:02:11

by André Apitzsch

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED

l8910 uses OCP8110 flash LED driver. Add it to the device tree.

Tested-by: Stephan Gerhold <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
---
Changes in v2:
- fix pinctrl-* order
- remove unnecessary newline
- Link to v1: https://lore.kernel.org/r/[email protected]
---
.../boot/dts/qcom/msm8916-longcheer-l8910.dts | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
index b79e80913af9..6046e2c1f158 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
@@ -20,6 +20,21 @@ chosen {
stdout-path = "serial0";
};

+ flash-led-controller {
+ compatible = "ocs,ocp8110";
+ enable-gpios = <&msmgpio 49 GPIO_ACTIVE_HIGH>;
+ flash-gpios = <&msmgpio 119 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-0 = <&camera_front_flash_default>;
+ pinctrl-names = "default";
+
+ flash_led: led {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ flash-max-timeout-us = <250000>;
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";

@@ -246,6 +261,13 @@ button_backlight_default: button-backlight-default-state {
bias-disable;
};

+ camera_front_flash_default: camera-front-flash-default-state {
+ pins = "gpio49", "gpio119";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
gpio_keys_default: gpio-keys-default-state {
pins = "gpio107";
function = "gpio";

---
base-commit: 533c54547153d46c0bf99ac0e396bed71f760c03
change-id: 20230514-x5_front_flash-c189e22b32fd

Best regards,
--
André Apitzsch <[email protected]>



2023-05-20 01:59:00

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED

On Wed, 17 May 2023 08:32:31 +0200, André Apitzsch wrote:
> l8910 uses OCP8110 flash LED driver. Add it to the device tree.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED
commit: 5d8d9330921770fb953e8e749bbd049ac0fae988

Best regards,
--
Bjorn Andersson <[email protected]>