2023-05-15 19:03:08

by Maya Matuszczyk

[permalink] [raw]
Subject: [PATCH] drm: panel-orientation-quirks: Change Air's quirk to support Air Plus

It turned out that Aya Neo Air Plus had a different board name than
expected.
This patch changes Aya Neo Air's quirk to account for that, as both
devices share "Air" in DMI product name.

Tested on Air claiming to be an Air Pro, and on Air Plus.

Signed-off-by: Maya Matuszczyk <[email protected]>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index b1a38e6ce2f8..0cb646cb04ee 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -179,7 +179,7 @@ static const struct dmi_system_id orientation_data[] = {
}, { /* AYA NEO AIR */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
- DMI_MATCH(DMI_BOARD_NAME, "AIR"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "AIR"),
},
.driver_data = (void *)&lcd1080x1920_leftside_up,
}, { /* AYA NEO NEXT */
--
2.40.1



2023-05-17 10:54:01

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] drm: panel-orientation-quirks: Change Air's quirk to support Air Plus

Hi,

On 5/15/23 20:48, Maya Matuszczyk wrote:
> It turned out that Aya Neo Air Plus had a different board name than
> expected.
> This patch changes Aya Neo Air's quirk to account for that, as both
> devices share "Air" in DMI product name.
>
> Tested on Air claiming to be an Air Pro, and on Air Plus.
>
> Signed-off-by: Maya Matuszczyk <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

I have just pushed this to drm-misc-fixes, so it should get
send to Linus with the next drm-fixes pull-req.

Regards,

Hans




> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index b1a38e6ce2f8..0cb646cb04ee 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -179,7 +179,7 @@ static const struct dmi_system_id orientation_data[] = {
> }, { /* AYA NEO AIR */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> - DMI_MATCH(DMI_BOARD_NAME, "AIR"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "AIR"),
> },
> .driver_data = (void *)&lcd1080x1920_leftside_up,
> }, { /* AYA NEO NEXT */