2023-05-16 08:35:15

by Axel Lin

Subject: [PATCH] regulator: tps6287x: Fix missing .n_voltages setting

Otherwise, regulator_list_voltage() will return -EINVAL.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/tps6287x-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/tps6287x-regulator.c b/drivers/regulator/tps6287x-regulator.c
index d7fc82175493..870e63ce3ff2 100644
--- a/drivers/regulator/tps6287x-regulator.c
+++ b/drivers/regulator/tps6287x-regulator.c
@@ -119,6 +119,7 @@ static struct regulator_desc tps6287x_reg = {
.ramp_mask = TPS6287X_CTRL1_VRAMP,
.ramp_delay_table = tps6287x_ramp_table,
.n_ramp_values = ARRAY_SIZE(tps6287x_ramp_table),
+ .n_voltages = 256,
.linear_ranges = tps6287x_voltage_ranges,
.n_linear_ranges = ARRAY_SIZE(tps6287x_voltage_ranges),
.linear_range_selectors = tps6287x_voltage_range_sel,
--
2.34.1

2023-05-17 11:06:42

by Mårten Lindahl

Subject: Re: [PATCH] regulator: tps6287x: Fix missing .n_voltages setting

Reviewed-by: Mårten Lindahl <[email protected]>

On 5/16/23 10:23, Axel Lin wrote:
> Otherwise, regulator_list_voltage() will return -EINVAL.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/tps6287x-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/tps6287x-regulator.c b/drivers/regulator/tps6287x-regulator.c
> index d7fc82175493..870e63ce3ff2 100644
> --- a/drivers/regulator/tps6287x-regulator.c
> +++ b/drivers/regulator/tps6287x-regulator.c
> @@ -119,6 +119,7 @@ static struct regulator_desc tps6287x_reg = {
> .ramp_mask = TPS6287X_CTRL1_VRAMP,
> .ramp_delay_table = tps6287x_ramp_table,
> .n_ramp_values = ARRAY_SIZE(tps6287x_ramp_table),
> + .n_voltages = 256,
> .linear_ranges = tps6287x_voltage_ranges,
> .n_linear_ranges = ARRAY_SIZE(tps6287x_voltage_ranges),
> .linear_range_selectors = tps6287x_voltage_range_sel,

2023-05-18 17:48:20

by Mark Brown

Subject: Re: [PATCH] regulator: tps6287x: Fix missing .n_voltages setting

On Tue, 16 May 2023 16:23:33 +0800, Axel Lin wrote:
> Otherwise, regulator_list_voltage() will return -EINVAL.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: tps6287x: Fix missing .n_voltages setting
commit: 15a1cd245d5b3cc6cf42ca9ceacf9a6dfc2e33b4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark