2023-05-16 09:20:57

by Dario Binacchi

Subject: [PATCH] drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H

The previous setting was related to the overall dimension and not to the
active display area.
In the "PHYSICAL SPECIFICATIONS" section, the datasheet shows the
following parameters:

----------------------------------------------------------
| Item | Specifications | unit |
----------------------------------------------------------
| Display area | 98.7 (W) x 57.5 (H) | mm |
----------------------------------------------------------
| Overall dimension | 105.5(W) x 67.2(H) x 4.96(D) | mm |
----------------------------------------------------------

Fixes: 966fea78adf23 ("drm/panel: simple: Add support for Ampire AM-480272H3TMQW-T01H")
Signed-off-by: Dario Binacchi <[email protected]>
---

drivers/gpu/drm/panel/panel-simple.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 065f378bba9d..d8efbcee9bc1 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -759,8 +759,8 @@ static const struct panel_desc ampire_am_480272h3tmqw_t01h = {
.num_modes = 1,
.bpc = 8,
.size = {
- .width = 105,
- .height = 67,
+ .width = 99,
+ .height = 58,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
--
2.32.0

2023-05-16 11:01:27

by Neil Armstrong

Subject: Re: [PATCH] drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H

On 16/05/2023 10:50, Dario Binacchi wrote:
> The previous setting was related to the overall dimension and not to the
> active display area.
> In the "PHYSICAL SPECIFICATIONS" section, the datasheet shows the
> following parameters:
>
> ----------------------------------------------------------
> | Item | Specifications | unit |
> ----------------------------------------------------------
> | Display area | 98.7 (W) x 57.5 (H) | mm |
> ----------------------------------------------------------
> | Overall dimension | 105.5(W) x 67.2(H) x 4.96(D) | mm |
> ----------------------------------------------------------
>
> Fixes: 966fea78adf23 ("drm/panel: simple: Add support for Ampire AM-480272H3TMQW-T01H")
> Signed-off-by: Dario Binacchi <[email protected]>
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 065f378bba9d..d8efbcee9bc1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -759,8 +759,8 @@ static const struct panel_desc ampire_am_480272h3tmqw_t01h = {
> .num_modes = 1,
> .bpc = 8,
> .size = {
> - .width = 105,
> - .height = 67,
> + .width = 99,
> + .height = 58,
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };

Reviewed-by: Neil Armstrong <[email protected]>

2023-05-26 08:11:03

by Neil Armstrong

Subject: Re: [PATCH] drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H

Hi,

On Tue, 16 May 2023 10:50:39 +0200, Dario Binacchi wrote:
> The previous setting was related to the overall dimension and not to the
> active display area.
> In the "PHYSICAL SPECIFICATIONS" section, the datasheet shows the
> following parameters:
>
> ----------------------------------------------------------
> | Item | Specifications | unit |
> ----------------------------------------------------------
> | Display area | 98.7 (W) x 57.5 (H) | mm |
> ----------------------------------------------------------
> | Overall dimension | 105.5(W) x 67.2(H) x 4.96(D) | mm |
> ----------------------------------------------------------
>
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/panel: simple: fix active size for Ampire AM-480272H3TMQW-T01H
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f24b49550814fdee4a98b9552e35e243ccafd4a8

--
Neil