The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom:
gcc: Add global clock controller driver for SM8250") already consumed it
on the clock. This fixes warnings like:
sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long
Fixes: 98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings")
Reviewed-by: Konrad Dybcio <[email protected]>
Acked-by: Rob Herring <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes in v2:
1. Re-word commit msg and fixes tag (Konrad)
2. Add tags
---
Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
index b752542ee20c..ead6665b9a45 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
@@ -23,11 +23,13 @@ properties:
clocks:
items:
- description: Board XO source
+ - description: Board active XO source
- description: Sleep clock source
clock-names:
items:
- const: bi_tcxo
+ - const: bi_tcxo_ao
- const: sleep_clk
required:
@@ -47,8 +49,9 @@ examples:
compatible = "qcom,gcc-sm8250";
reg = <0x00100000 0x1f0000>;
clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&rpmhcc RPMH_CXO_CLK_A>,
<&sleep_clk>;
- clock-names = "bi_tcxo", "sleep_clk";
+ clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
--
2.34.1
The GCC clock controller needs CX power domain, at least according to
DTS:
sc7280-herobrine-crd-pro.dtb: clock-controller@100000: Unevaluated properties are not allowed ('power-domains' was unexpected)
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes in v2:
1. Add tags
---
.../devicetree/bindings/clock/qcom,gcc-sc7280.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml
index 947b47168cec..ff0b18bbb0fc 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sc7280.yaml
@@ -43,6 +43,10 @@ properties:
- const: ufs_phy_tx_symbol_0_clk
- const: usb3_phy_wrapper_gcc_usb30_pipe_clk
+ power-domains:
+ items:
+ - description: CX domain
+
required:
- compatible
- clocks
@@ -56,6 +60,8 @@ unevaluatedProperties: false
examples:
- |
#include <dt-bindings/clock/qcom,rpmh.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
clock-controller@100000 {
compatible = "qcom,gcc-sc7280";
reg = <0x00100000 0x1f0000>;
@@ -71,6 +77,7 @@ examples:
"pcie_1_pipe_clk", "ufs_phy_rx_symbol_0_clk",
"ufs_phy_rx_symbol_1_clk", "ufs_phy_tx_symbol_0_clk",
"usb3_phy_wrapper_gcc_usb30_pipe_clk";
+ power-domains = <&rpmhpd SC7280_CX>;
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
--
2.34.1
On 16/05/2023 11:52, Krzysztof Kozlowski wrote:
> The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom:
> gcc: Add global clock controller driver for SM8250") already consumed it
> on the clock. This fixes warnings like:
>
> sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long
>
> Fixes: 98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings")
> Reviewed-by: Konrad Dybcio <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> Reviewed-by: Stephen Boyd <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes in v2:
> 1. Re-word commit msg and fixes tag (Konrad)
> 2. Add tags
> ---
> Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> index b752542ee20c..ead6665b9a45 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml
> @@ -23,11 +23,13 @@ properties:
> clocks:
> items:
> - description: Board XO source
> + - description: Board active XO source
> - description: Sleep clock source
>
> clock-names:
> items:
> - const: bi_tcxo
> + - const: bi_tcxo_ao
> - const: sleep_clk
>
> required:
> @@ -47,8 +49,9 @@ examples:
> compatible = "qcom,gcc-sm8250";
> reg = <0x00100000 0x1f0000>;
> clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&rpmhcc RPMH_CXO_CLK_A>,
> <&sleep_clk>;
> - clock-names = "bi_tcxo", "sleep_clk";
> + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
LGTM
Reviewed-by: Bryan O'Donoghue <[email protected]>
On Tue, 16 May 2023 12:52:39 +0200, Krzysztof Kozlowski wrote:
> The initial SM8250 GCC driver added in commit 3e5770921a88 ("clk: qcom:
> gcc: Add global clock controller driver for SM8250") already consumed it
> on the clock. This fixes warnings like:
>
> sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long
>
>
> [...]
Applied, thanks!
[1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock
commit: 2310ab77f1ee2611e34345ca1746c9e8aaa5bc31
[2/3] dt-bindings: clock: qcom,gcc-sc7180: document CX power domain
commit: 21a95637a3fda45e6d3fd7a57d6ada204e28e484
[3/3] dt-bindings: clock: qcom,gcc-sc7280: document CX power domain
commit: 7a52084ae14f49582b0ce19106cdad094499e204
Best regards,
--
Bjorn Andersson <[email protected]>