2023-05-16 16:07:59

by Andre Przywara

[permalink] [raw]
Subject: Re: [PATCH 03/13] ARM: highbank: add missing include

On Tue, 16 May 2023 17:30:59 +0200
Arnd Bergmann <[email protected]> wrote:

> From: Arnd Bergmann <[email protected]>
>
> highbank_pm_init() is declared in core.h this is not included in the
> file that defines it.
>
> arch/arm/mach-highbank/pm.c:43:13: error: no previous prototype for 'highbank_pm_init'
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Andre Przywara <[email protected]>

Cheers,
Andre

> ---
> arch/arm/mach-highbank/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-highbank/pm.c b/arch/arm/mach-highbank/pm.c
> index 561941baeda9..3fdbdb83113b 100644
> --- a/arch/arm/mach-highbank/pm.c
> +++ b/arch/arm/mach-highbank/pm.c
> @@ -12,6 +12,8 @@
>
> #include <uapi/linux/psci.h>
>
> +#include "core.h"
> +
> #define HIGHBANK_SUSPEND_PARAM \
> ((0 << PSCI_0_2_POWER_STATE_ID_SHIFT) | \
> (1 << PSCI_0_2_POWER_STATE_AFFL_SHIFT) | \