2023-05-16 18:47:18

by Osama Muhammad

Subject: [PATCH] ras:debugfs.c: Fix error checking for debugfs_create_dir

This patch fixes the error checking in debugfs.c in debugfs_create_dir.
The correct way to check if an error occurred is 'IS_ERR' inline function.

Signed-off-by: Osama Muhammad <[email protected]>
---
drivers/ras/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index f0a6391b1146..ffb973c328e3 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -46,7 +46,7 @@ int __init ras_add_daemon_trace(void)

fentry = debugfs_create_file("daemon_active", S_IRUSR, ras_debugfs_dir,
NULL, &trace_fops);
- if (!fentry)
+ if (IS_ERR(fentry))
return -ENODEV;

return 0;
--
2.34.1

2023-05-16 19:37:22

by tip-bot2 for Alexey Makhalov

Subject: [tip: ras/core] ras/debugfs: Fix error checking for debugfs_create_dir()

The following commit has been merged into the ras/core branch of tip:

Commit-ID: 2a1d18a5dc5056825b8e9527d188130da6256efc
Gitweb: https://git.kernel.org/tip/2a1d18a5dc5056825b8e9527d188130da6256efc
Author: Osama Muhammad <[email protected]>
AuthorDate: Tue, 16 May 2023 23:29:27 +05:00
Committer: Borislav Petkov (AMD) <[email protected]>
CommitterDate: Tue, 16 May 2023 21:12:23 +02:00

ras/debugfs: Fix error checking for debugfs_create_dir()

Check the return value of debugfs_create_dir() properly.

[ bp: Rewrite commit message. ]

Signed-off-by: Osama Muhammad <[email protected]>
Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/ras/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index f0a6391..ffb973c 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -46,7 +46,7 @@ int __init ras_add_daemon_trace(void)

fentry = debugfs_create_file("daemon_active", S_IRUSR, ras_debugfs_dir,
NULL, &trace_fops);
- if (!fentry)
+ if (IS_ERR(fentry))
return -ENODEV;

return 0;