2023-05-16 23:58:54

by Aaro Koskinen

[permalink] [raw]
Subject: Re: [PATCH 08/13] ARM: omap2: fix missing tick_broadcast() prototype

On Tue, May 16, 2023 at 05:31:04PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> omap2 contains a hack to define tick_broadcast() on non-SMP
> configurations in place of the normal SMP definition. This one
> causes a warning because of a missing prototype:
>
> arch/arm/mach-omap2/board-generic.c:44:6: error: no previous prototype for 'tick_broadcast'
>
> Make sure to always include the header with the declaration.
>
> Fixes: d86ad463d670 ("ARM: OMAP2+: Fix regression for using local timer on non-SMP SoCs")
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Aaro Koskinen <[email protected]>

> ---
> arch/arm/mach-omap2/board-generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index 853409b341a3..7aa41841edd4 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -13,6 +13,7 @@
> #include <linux/of_platform.h>
> #include <linux/irqdomain.h>
> #include <linux/clocksource.h>
> +#include <linux/clockchips.h>
>
> #include <asm/setup.h>
> #include <asm/mach/arch.h>
> --
> 2.39.2
>