LinuxLists.cc - Re: [PATCH 07/13] ARM: omap1: add missing include

2023-05-17 00:14:43

Subject: Re: [PATCH 07/13] ARM: omap1: add missing include

On Tue, May 16, 2023 at 05:31:03PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The omap_serial_wakeup_init() declaration is not visible where it is
> defined, so make sure "common.h" is included here, avoiding:
>
> arch/arm/mach-omap1/serial.c:221:12: error: no previous prototype for 'omap_serial_wakeup_init' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Aaro Koskinen <[email protected]>

A.

> ---
> arch/arm/mach-omap1/serial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap1/serial.c b/arch/arm/mach-omap1/serial.c
> index 96f59110d649..f25b94c86aec 100644
> --- a/arch/arm/mach-omap1/serial.c
> +++ b/arch/arm/mach-omap1/serial.c
> @@ -19,6 +19,7 @@
>
> #include <asm/mach-types.h>
>
> +#include "common.h"
> #include "serial.h"
> #include "mux.h"
> #include "pm.h"
> --
> 2.39.2
>

2023-05-17 06:06:13

by Tony Lindgren

[permalink] [raw]

Subject: Re: [PATCH 07/13] ARM: omap1: add missing include

* Aaro Koskinen <[email protected]> [230516 23:18]:
> On Tue, May 16, 2023 at 05:31:03PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <[email protected]>
> >
> > The omap_serial_wakeup_init() declaration is not visible where it is
> > defined, so make sure "common.h" is included here, avoiding:
> >
> > arch/arm/mach-omap1/serial.c:221:12: error: no previous prototype for 'omap_serial_wakeup_init' [-Werror=missing-prototypes]
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> Acked-by: Aaro Koskinen <[email protected]>

Acked-by: Tony Lindgren <[email protected]>

2023-05-17 06:10:34

by Tony Lindgren

[permalink] [raw]