2023-05-17 07:27:33

by Christoph Hellwig

[permalink] [raw]
Subject: [PATCH] squashfs: don't include buffer_head.h

Squashfs has stopped using buffers heads in 93e72b3c612adcaca1
("squashfs: migrate from ll_rw_block usage to BIO").

Signed-off-by: Christoph Hellwig <[email protected]>
---
fs/squashfs/block.c | 1 -
fs/squashfs/decompressor.c | 1 -
fs/squashfs/decompressor_multi_percpu.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c
index bed3bb8b27fa3d..cb4e48baa4ba5b 100644
--- a/fs/squashfs/block.c
+++ b/fs/squashfs/block.c
@@ -18,7 +18,6 @@
#include <linux/vfs.h>
#include <linux/slab.h>
#include <linux/string.h>
-#include <linux/buffer_head.h>
#include <linux/bio.h>

#include "squashfs_fs.h"
diff --git a/fs/squashfs/decompressor.c b/fs/squashfs/decompressor.c
index 8893cb9b419833..a676084be27e43 100644
--- a/fs/squashfs/decompressor.c
+++ b/fs/squashfs/decompressor.c
@@ -11,7 +11,6 @@
#include <linux/types.h>
#include <linux/mutex.h>
#include <linux/slab.h>
-#include <linux/buffer_head.h>

#include "squashfs_fs.h"
#include "squashfs_fs_sb.h"
diff --git a/fs/squashfs/decompressor_multi_percpu.c b/fs/squashfs/decompressor_multi_percpu.c
index 1dfadf76ed9ae8..8a218e7c2390f2 100644
--- a/fs/squashfs/decompressor_multi_percpu.c
+++ b/fs/squashfs/decompressor_multi_percpu.c
@@ -7,7 +7,6 @@
#include <linux/types.h>
#include <linux/slab.h>
#include <linux/percpu.h>
-#include <linux/buffer_head.h>
#include <linux/local_lock.h>

#include "squashfs_fs.h"
--
2.39.2



2023-05-17 17:53:10

by Phillip Lougher

[permalink] [raw]
Subject: Re: [PATCH] squashfs: don't include buffer_head.h

On 17/05/2023 08:16, Christoph Hellwig wrote:
> Squashfs has stopped using buffers heads in 93e72b3c612adcaca1
> ("squashfs: migrate from ll_rw_block usage to BIO").
>
> Signed-off-by: Christoph Hellwig <[email protected]>

Reviewed-by: Phillip Lougher <[email protected]>