Changes since v5:
----------------
- v5 can be viewed here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Addressed Mani's comment and added Fixes tag for [PATCH 1/6].
Also collected his Ack for this patch.
- Fixed [PATCH 4/6] as per Greg's comments and added a separate patch
for identation issues -> [PATCH 3/6].
Changes since v4:
----------------
- v4 can be viewed here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Addressed Konrad's review comments regarding EUD driver code.
- Also collected his R-B for [PATCH 4/5 and 5/5].
- Fixed the dt-bindings as per Krzysztof's comments.
Changes since v3:
----------------
- v3 can be viewed here: https://www.spinics.net/lists/linux-arm-msm/msg137025.html
- Addressed Konrad's review comments regarding mainly the driver code.
Also fixed the .dtsi as per his comments.
- Also collected his R-B for [PATCH 1/5].
Changes since v2:
----------------
- v2 can be viewed here: https://www.spinics.net/lists/linux-arm-msm/msg137025.html
- Addressed Bjorn and Krzysztof's comments.
- Added [PATCH 1/5] which fixes the 'qcom_eud' sysfs path.
- Added [PATCH 5/5] to enable EUD for Qualcomm QRB4210-RB2 boards.
Changes since v1:
----------------
- v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/[email protected]
- Added Krzysztof in Cc list.
- Fixed the following issue reported by kernel test bot:
>> ERROR: modpost: "qcom_scm_io_writel" [drivers/usb/misc/qcom_eud.ko] undefined!
This series adds the dt-binding and driver support for SM6115 / SM4250
EUD (Embedded USB Debugger) block available on Qualcomm SoCs.
It also enables the same for QRB4210-RB2 boards by default (the user
still needs to enable the same via sysfs).
The EUD is a mini-USB hub implemented on chip to support the USB-based debug
and trace capabilities.
EUD driver listens to events like USB attach or detach and then
informs the USB about these events via ROLE-SWITCH.
Bhupesh Sharma (6):
usb: misc: eud: Fix eud sysfs path (use 'qcom_eud')
dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support
usb: misc: eud: Fix indentation issues
usb: misc: eud: Add driver support for SM6115 / SM4250
arm64: dts: qcom: sm6115: Add EUD dt node and dwc3 connector
arm64: dts: qcom: qrb4210-rb2: Enable EUD debug peripheral
Documentation/ABI/testing/sysfs-driver-eud | 2 +-
.../bindings/soc/qcom/qcom,eud.yaml | 42 ++++++++++-
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 27 +++++++-
arch/arm64/boot/dts/qcom/sm6115.dtsi | 50 ++++++++++++++
drivers/usb/misc/Kconfig | 2 +-
drivers/usb/misc/qcom_eud.c | 69 +++++++++++++++++--
6 files changed, 179 insertions(+), 13 deletions(-)
--
2.38.1
Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
needs to be set first to 'enable' the eud module.
So, update the dt-bindings to accommodate the third register
property (TCSR Base) required by the driver on these SoCs.
Signed-off-by: Bhupesh Sharma <[email protected]>
---
.../bindings/soc/qcom/qcom,eud.yaml | 42 +++++++++++++++++--
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
index f2c5ec7e6437..9c64b5d9504f 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
@@ -18,12 +18,16 @@ properties:
items:
- enum:
- qcom,sc7280-eud
+ - qcom,sm6115-eud
- const: qcom,eud
reg:
- items:
- - description: EUD Base Register Region
- - description: EUD Mode Manager Register
+ minItems: 2
+ maxItems: 3
+
+ reg-names:
+ minItems: 2
+ maxItems: 3
interrupts:
description: EUD interrupt
@@ -52,6 +56,38 @@ required:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc7280-eud
+ then:
+ properties:
+ reg:
+ maxItems: 2
+ reg-names:
+ items:
+ - const: eud-base
+ - const: eud-mode-mgr
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm6115-eud
+ then:
+ properties:
+ reg:
+ maxItems: 3
+ reg-names:
+ items:
+ - const: eud-base
+ - const: eud-mode-mgr
+ - const: tcsr-base
+
examples:
- |
eud@88e0000 {
--
2.38.1
On 17/05/2023 23:17, Bhupesh Sharma wrote:
> Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
>
> On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
> needs to be set first to 'enable' the eud module.
>
> So, update the dt-bindings to accommodate the third register
> property (TCSR Base) required by the driver on these SoCs.
>
> Signed-off-by: Bhupesh Sharma <[email protected]>
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Also - no improvements.
Best regards,
Krzysztof
Hi Krzysztof,
On Thu, 18 May 2023 at 13:08, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 17/05/2023 23:17, Bhupesh Sharma wrote:
> > Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
> >
> > On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
> > needs to be set first to 'enable' the eud module.
> >
> > So, update the dt-bindings to accommodate the third register
> > property (TCSR Base) required by the driver on these SoCs.
> >
> > Signed-off-by: Bhupesh Sharma <[email protected]>
>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
>
> Also - no improvements.
Oops, seems I missed your review on v5 due to a label filter for
'linux-usb' list.
I will take care in future versions.
Please let me know if the R-B tag is still valid though :)
Thanks.