2023-05-18 09:50:43

by Charles Keepax

[permalink] [raw]
Subject: [PATCH 2/2] spi: spi-cadence: Add missing kernel doc for clk_rate in cdns_spi

Add the missing kernel documentation to silence the build warning.

Signed-off-by: Charles Keepax <[email protected]>
---

New since v1 of the series, but might as well fix this build warning
too.

Thanks,
Charles

drivers/spi/spi-cadence.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 26e6633693196..de8fe3c5becbb 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -102,6 +102,7 @@
* @regs: Virtual address of the SPI controller registers
* @ref_clk: Pointer to the peripheral clock
* @pclk: Pointer to the APB clock
+ * @clk_rate: Reference clock frequency, taken from @ref_clk
* @speed_hz: Current SPI bus clock speed in Hz
* @txbuf: Pointer to the TX buffer
* @rxbuf: Pointer to the RX buffer
--
2.30.2



2023-05-22 10:20:40

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: spi-cadence: Add missing kernel doc for clk_rate in cdns_spi

On Thu, May 18, 2023 at 10:39:27AM +0100, Charles Keepax wrote:
> Add the missing kernel documentation to silence the build warning.
>
> Signed-off-by: Charles Keepax <[email protected]>
> ---
>
> New since v1 of the series, but might as well fix this build warning
> too.

Sending this without the "v2" breaks threading and makes it hard to
handle with tooling, versioning applies to the patch series, not to
individual patches.


Attachments:
(No filename) (456.00 B)
signature.asc (499.00 B)
Download all attachments

2023-05-22 14:29:36

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: spi-cadence: Add missing kernel doc for clk_rate in cdns_spi

On Mon, May 22, 2023 at 10:52:17AM +0100, Mark Brown wrote:
> On Thu, May 18, 2023 at 10:39:27AM +0100, Charles Keepax wrote:
> > Add the missing kernel documentation to silence the build warning.
> >
> > Signed-off-by: Charles Keepax <[email protected]>
> > ---
> >
> > New since v1 of the series, but might as well fix this build warning
> > too.
>
> Sending this without the "v2" breaks threading and makes it hard to
> handle with tooling, versioning applies to the patch series, not to
> individual patches.

Apologies do you want me to resend?

Thanks,
Charles

2023-05-22 14:38:12

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: spi-cadence: Add missing kernel doc for clk_rate in cdns_spi

On Mon, May 22, 2023 at 02:21:06PM +0000, Charles Keepax wrote:
> On Mon, May 22, 2023 at 10:52:17AM +0100, Mark Brown wrote:

> > Sending this without the "v2" breaks threading and makes it hard to
> > handle with tooling, versioning applies to the patch series, not to
> > individual patches.

> Apologies do you want me to resend?

Just this patch please, the first patch is still going through CI but I
didn't figure out how to push this into the tooling.


Attachments:
(No filename) (471.00 B)
signature.asc (499.00 B)
Download all attachments