2023-05-18 14:15:27

by Tom Rix

Subject: [PATCH] mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static

smatch reports
mm/page_alloc.c:247:5: warning: symbol
'sysctl_lowmem_reserve_ratio' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

Signed-off-by: Tom Rix <[email protected]>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 1023f41de2fb..8032fffa425a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order,
* TBD: should special case ZONE_DMA32 machines here - in those we normally
* don't need any ZONE_NORMAL reservation
*/
-int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
+static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
#ifdef CONFIG_ZONE_DMA
[ZONE_DMA] = 256,
#endif
--
2.27.0

2023-05-19 01:22:49

by Kefeng Wang

Subject: Re: [PATCH] mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static

On 2023/5/18 22:11, Tom Rix wrote:
> smatch reports
> mm/page_alloc.c:247:5: warning: symbol
> 'sysctl_lowmem_reserve_ratio' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Missing this one, Reviewed-by: Kefeng Wang <[email protected]>

> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1023f41de2fb..8032fffa425a 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order,
> * TBD: should special case ZONE_DMA32 machines here - in those we normally
> * don't need any ZONE_NORMAL reservation
> */
> -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
> +static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
> #ifdef CONFIG_ZONE_DMA
> [ZONE_DMA] = 256,
> #endif