2023-05-19 05:35:09

by Anshuman Khandual

Subject: [PATCH V3 6/6] coresight: platform: acpi: Ignore the absence of graph

From: Suzuki K Poulose <[email protected]>

Some components may not have graph connections for describing
the trace path. e.g., ETE, where it could directly use the per
CPU TRBE. Ignore the absence of graph connections

Signed-off-by: Suzuki K Poulose <[email protected]>
Signed-off-by: Anshuman Khandual <[email protected]>
---
drivers/hwtracing/coresight/coresight-platform.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
index 475899714104..c4b4fbde8550 100644
--- a/drivers/hwtracing/coresight/coresight-platform.c
+++ b/drivers/hwtracing/coresight/coresight-platform.c
@@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev,

pdata->nr_inport = pdata->nr_outport = 0;
graph = acpi_get_coresight_graph(adev);
+ /*
+ * There are no graph connections, which is fine for some components.
+ * e.g., ETE
+ */
if (!graph)
- return -ENOENT;
+ return 0;

nlinks = graph->package.elements[2].integer.value;
if (!nlinks)
--
2.25.1

2023-05-19 12:44:45

by Suzuki K Poulose

Subject: Re: [PATCH V3 6/6] coresight: platform: acpi: Ignore the absence of graph

On 19/05/2023 06:21, Anshuman Khandual wrote:
> From: Suzuki K Poulose <[email protected]>
>
> Some components may not have graph connections for describing
> the trace path. e.g., ETE, where it could directly use the per
> CPU TRBE. Ignore the absence of graph connections
>
> Signed-off-by: Suzuki K Poulose <[email protected]>
> Signed-off-by: Anshuman Khandual <[email protected]>

Please could you move this before the Patch 5, where we add
ACPI support for etm4x with system instructions ? That way
the support is up with that patch, without an error that
is fixed by this patch.

Suzuki


> ---
> drivers/hwtracing/coresight/coresight-platform.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 475899714104..c4b4fbde8550 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev,
>
> pdata->nr_inport = pdata->nr_outport = 0;
> graph = acpi_get_coresight_graph(adev);
> + /*
> + * There are no graph connections, which is fine for some components.
> + * e.g., ETE
> + */
> if (!graph)
> - return -ENOENT;
> + return 0;
>
> nlinks = graph->package.elements[2].integer.value;
> if (!nlinks)

2023-05-23 02:59:10

by Anshuman Khandual

Subject: Re: [PATCH V3 6/6] coresight: platform: acpi: Ignore the absence of graph

On 5/19/23 18:10, Suzuki K Poulose wrote:
> On 19/05/2023 06:21, Anshuman Khandual wrote:
>> From: Suzuki K Poulose <[email protected]>
>>
>> Some components may not have graph connections for describing
>> the trace path. e.g., ETE, where it could directly use the per
>> CPU TRBE. Ignore the absence of graph connections
>>
>> Signed-off-by: Suzuki K Poulose <[email protected]>
>> Signed-off-by: Anshuman Khandual <[email protected]>
>
> Please could you move this before the Patch 5, where we add
> ACPI support for etm4x with system instructions ? That way
> the support is up with that patch, without an error that
> is fixed by this patch.

Sure, will move it before adding the ACPI support patch.

>
> Suzuki
>
>
>> ---
>>   drivers/hwtracing/coresight/coresight-platform.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
>> index 475899714104..c4b4fbde8550 100644
>> --- a/drivers/hwtracing/coresight/coresight-platform.c
>> +++ b/drivers/hwtracing/coresight/coresight-platform.c
>> @@ -692,8 +692,12 @@ static int acpi_coresight_parse_graph(struct acpi_device *adev,
>>         pdata->nr_inport = pdata->nr_outport = 0;
>>       graph = acpi_get_coresight_graph(adev);
>> +    /*
>> +     * There are no graph connections, which is fine for some components.
>> +     * e.g., ETE
>> +     */
>>       if (!graph)
>> -        return -ENOENT;
>> +        return 0;
>>         nlinks = graph->package.elements[2].integer.value;
>>       if (!nlinks)
>