2023-05-19 20:55:22

by Alexandru Ardelean

Subject: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level

From: Yannick Fertre <[email protected]>

Add new property to set a brightness by default at probe.

Reviewed-by: Philippe CORNU <[email protected]>
Signed-off-by: Yannick Fertre <[email protected]>
Signed-off-by: Alexandru Ardelean <[email protected]>
---

Link to original patch:
https://github.com/STMicroelectronics/linux/commit/c4067d7bd883c6fa14ffd49892c4ce663cdafe98

drivers/video/backlight/gpio_backlight.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 6f78d928f054..d3fa3a8bef4d 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -53,6 +53,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
struct backlight_device *bl;
struct gpio_backlight *gbl;
int ret, init_brightness, def_value;
+ u32 value;

gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
if (gbl == NULL)
@@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev)
else
bl->props.power = FB_BLANK_UNBLANK;

- bl->props.brightness = 1;
+ ret = device_property_read_u32(dev, "default-brightness-level", &value);
+ if (!ret && value <= props.max_brightness)
+ bl->props.brightness = value;
+ else
+ bl->props.brightness = 1;

init_brightness = backlight_get_brightness(bl);
ret = gpiod_direction_output(gbl->gpiod, init_brightness);
--
2.40.1

2023-05-26 10:38:08

by Daniel Thompson

Subject: Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level

On Fri, May 19, 2023 at 11:05:19PM +0300, Alexandru Ardelean wrote:
> From: Yannick Fertre <[email protected]>
>
> Add new property to set a brightness by default at probe.
>
> Reviewed-by: Philippe CORNU <[email protected]>
> Signed-off-by: Yannick Fertre <[email protected]>
> Signed-off-by: Alexandru Ardelean <[email protected]>

Patch order should be reversed for v2. Nevertheless:
Reviewed-by: Daniel Thompson <[email protected]>


Daniel.

> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> int ret, init_brightness, def_value;
> + u32 value;
>
> gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> @@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> else
> bl->props.power = FB_BLANK_UNBLANK;
>
> - bl->props.brightness = 1;
> + ret = device_property_read_u32(dev, "default-brightness-level", &value);
> + if (!ret && value <= props.max_brightness)
> + bl->props.brightness = value;
> + else
> + bl->props.brightness = 1;
>
> init_brightness = backlight_get_brightness(bl);
> ret = gpiod_direction_output(gbl->gpiod, init_brightness);
> --
> 2.40.1
>

2023-05-26 12:14:00

by Philippe CORNU

Subject: Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level

On 5/19/23 22:05, Alexandru Ardelean wrote:
> From: Yannick Fertre <[email protected]>
>
> Add new property to set a brightness by default at probe.
>
> Reviewed-by: Philippe CORNU <[email protected]>

Hi Alexandru,

Many thanks for your patch.

You have sent a patch originally pushed on the STMicroelectronics github
as mentioned in your commit message (no problem with that :-). But, the
"Reviewed-by" inside this github patch is linked to our gerrit STM
internal server so you can not use it directly for mainlining this patch.

So please, re-send your this patch without my "Reviewed-by".

Many thanks
Philippe :-)


> Signed-off-by: Yannick Fertre <[email protected]>
> Signed-off-by: Alexandru Ardelean <[email protected]>
> ---
>
> Link to original patch:
> https://github.com/STMicroelectronics/linux/commit/c4067d7bd883c6fa14ffd49892c4ce663cdafe98
>
> drivers/video/backlight/gpio_backlight.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 6f78d928f054..d3fa3a8bef4d 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -53,6 +53,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> int ret, init_brightness, def_value;
> + u32 value;
>
> gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> @@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> else
> bl->props.power = FB_BLANK_UNBLANK;
>
> - bl->props.brightness = 1;
> + ret = device_property_read_u32(dev, "default-brightness-level", &value);
> + if (!ret && value <= props.max_brightness)
> + bl->props.brightness = value;
> + else
> + bl->props.brightness = 1;
>
> init_brightness = backlight_get_brightness(bl);
> ret = gpiod_direction_output(gbl->gpiod, init_brightness);

2023-05-29 07:07:07

by Alexandru Ardelean

Subject: Re: [PATCH 1/2] backlight: gpio_backlight: add new property default-brightness-level

On Fri, May 26, 2023 at 3:04 PM Philippe CORNU
<[email protected]> wrote:
>
>
> On 5/19/23 22:05, Alexandru Ardelean wrote:
> > From: Yannick Fertre <[email protected]>
> >
> > Add new property to set a brightness by default at probe.
> >
> > Reviewed-by: Philippe CORNU <[email protected]>
>
> Hi Alexandru,
>
> Many thanks for your patch.
>
> You have sent a patch originally pushed on the STMicroelectronics github
> as mentioned in your commit message (no problem with that :-). But, the
> "Reviewed-by" inside this github patch is linked to our gerrit STM
> internal server so you can not use it directly for mainlining this patch.
>
> So please, re-send your this patch without my "Reviewed-by".

ack
will do

>
> Many thanks
> Philippe :-)
>
>
> > Signed-off-by: Yannick Fertre <[email protected]>
> > Signed-off-by: Alexandru Ardelean <[email protected]>
> > ---
> >
> > Link to original patch:
> > https://github.com/STMicroelectronics/linux/commit/c4067d7bd883c6fa14ffd49892c4ce663cdafe98
> >
> > drivers/video/backlight/gpio_backlight.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> > index 6f78d928f054..d3fa3a8bef4d 100644
> > --- a/drivers/video/backlight/gpio_backlight.c
> > +++ b/drivers/video/backlight/gpio_backlight.c
> > @@ -53,6 +53,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> > struct backlight_device *bl;
> > struct gpio_backlight *gbl;
> > int ret, init_brightness, def_value;
> > + u32 value;
> >
> > gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> > if (gbl == NULL)
> > @@ -93,7 +94,11 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> > else
> > bl->props.power = FB_BLANK_UNBLANK;
> >
> > - bl->props.brightness = 1;
> > + ret = device_property_read_u32(dev, "default-brightness-level", &value);
> > + if (!ret && value <= props.max_brightness)
> > + bl->props.brightness = value;
> > + else
> > + bl->props.brightness = 1;
> >
> > init_brightness = backlight_get_brightness(bl);
> > ret = gpiod_direction_output(gbl->gpiod, init_brightness);