2023-05-22 08:42:51

by Herve Codina

Subject: [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC

This series fixes issues raised by the kernel test robot
https://lore.kernel.org/oe-kbuild-all/[email protected]/

In COMPILE_TEST configurations, TSA and QMC need CONFIG_CPM to be set in
order to compile and CPM uart needs CONFIG_CPM2.

Best regards,
Hervé

Herve Codina (2):
soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST
serial: cpm_uart: Fix a COMPILE_TEST dependency

drivers/soc/fsl/qe/Kconfig | 4 ++--
drivers/tty/serial/Kconfig | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

--
2.40.1

2023-05-22 08:56:30

by Herve Codina

Subject: [PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST

In order to compile tsa.c and qmc.c, CONFIG_CPM must be set.

Without this dependency, the linker fails with some missing
symbols for COMPILE_TEST configurations that need QMC without
enabling CPM.

Signed-off-by: Herve Codina <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
drivers/soc/fsl/qe/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index 7268c2fbcbc1..e0d096607fef 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -36,7 +36,7 @@ config UCC
config CPM_TSA
tristate "CPM TSA support"
depends on OF && HAS_IOMEM
- depends on CPM1 || COMPILE_TEST
+ depends on CPM1 || (CPM && COMPILE_TEST)
help
Freescale CPM Time Slot Assigner (TSA)
controller.
@@ -47,7 +47,7 @@ config CPM_TSA
config CPM_QMC
tristate "CPM QMC support"
depends on OF && HAS_IOMEM
- depends on CPM1 || (FSL_SOC && COMPILE_TEST)
+ depends on CPM1 || (FSL_SOC && CPM && COMPILE_TEST)
depends on CPM_TSA
help
Freescale CPM QUICC Multichannel Controller
--
2.40.1

2023-05-23 07:56:01

by Jiri Slaby

Subject: Re: [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC

On 22. 05. 23, 10:20, Herve Codina wrote:
> This series fixes issues raised by the kernel test robot
> https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> In COMPILE_TEST configurations, TSA and QMC need CONFIG_CPM to be set in
> order to compile and CPM uart needs CONFIG_CPM2.

Ah, perfect. Greg, please disregard my revert posted at:
https://lore.kernel.org/all/[email protected]/

and take these instead.

Thanks.

> Best regards,
> Hervé
>
> Herve Codina (2):
> soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST
> serial: cpm_uart: Fix a COMPILE_TEST dependency
>
> drivers/soc/fsl/qe/Kconfig | 4 ++--
> drivers/tty/serial/Kconfig | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>

--
js