2023-05-22 16:34:56

by Min-Hua Chen

Subject: [PATCH] soc: qcom: rpmpd: use correct __le32 type

Use cpu_to_le32 to cast constants to __le32 before comparing
them with __le32 type pd->key. This fixes the following sparse
warnings:

drivers/soc/qcom/rpmpd.c:895:31: sparse: warning: restricted __le32 degrades to integer
drivers/soc/qcom/rpmpd.c:896:15: sparse: warning: restricted __le32 degrades to integer

Signed-off-by: Min-Hua Chen <[email protected]>
---
drivers/soc/qcom/rpmpd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
index f8397dcb146c..99b017fd76b7 100644
--- a/drivers/soc/qcom/rpmpd.c
+++ b/drivers/soc/qcom/rpmpd.c
@@ -892,8 +892,8 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
pd->corner = state;

/* Always send updates for vfc and vfl */
- if (!pd->enabled && pd->key != KEY_FLOOR_CORNER &&
- pd->key != KEY_FLOOR_LEVEL)
+ if (!pd->enabled && pd->key != cpu_to_le32(KEY_FLOOR_CORNER) &&
+ pd->key != cpu_to_le32(KEY_FLOOR_LEVEL))
goto out;

ret = rpmpd_aggregate_corner(pd);
--
2.34.1

2023-05-22 16:35:20

by Konrad Dybcio

Subject: Re: [PATCH] soc: qcom: rpmpd: use correct __le32 type

On 22.05.2023 18:07, Min-Hua Chen wrote:
> Use cpu_to_le32 to cast constants to __le32 before comparing
> them with __le32 type pd->key. This fixes the following sparse
> warnings:
>
> drivers/soc/qcom/rpmpd.c:895:31: sparse: warning: restricted __le32 degrades to integer
> drivers/soc/qcom/rpmpd.c:896:15: sparse: warning: restricted __le32 degrades to integer
>
> Signed-off-by: Min-Hua Chen <[email protected]>
> ---
I wonder if our drivers are capable of booting and working properly
in BE..

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/soc/qcom/rpmpd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> index f8397dcb146c..99b017fd76b7 100644
> --- a/drivers/soc/qcom/rpmpd.c
> +++ b/drivers/soc/qcom/rpmpd.c
> @@ -892,8 +892,8 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
> pd->corner = state;
>
> /* Always send updates for vfc and vfl */
> - if (!pd->enabled && pd->key != KEY_FLOOR_CORNER &&
> - pd->key != KEY_FLOOR_LEVEL)
> + if (!pd->enabled && pd->key != cpu_to_le32(KEY_FLOOR_CORNER) &&
> + pd->key != cpu_to_le32(KEY_FLOOR_LEVEL))
> goto out;
>
> ret = rpmpd_aggregate_corner(pd);

2023-05-25 05:36:42

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: rpmpd: use correct __le32 type

On Tue, 23 May 2023 00:07:56 +0800, Min-Hua Chen wrote:
> Use cpu_to_le32 to cast constants to __le32 before comparing
> them with __le32 type pd->key. This fixes the following sparse
> warnings:
>
> drivers/soc/qcom/rpmpd.c:895:31: sparse: warning: restricted __le32 degrades to integer
> drivers/soc/qcom/rpmpd.c:896:15: sparse: warning: restricted __le32 degrades to integer
>
> [...]

Applied, thanks!

[1/1] soc: qcom: rpmpd: use correct __le32 type
commit: 4b819e7e89fedc90150a78152bfa6e6e3534e64b

Best regards,
--
Bjorn Andersson <[email protected]>