This patch set enables tsens in IPQ9574
Depends on
https://lore.kernel.org/linux-arm-msm/[email protected]/
[v4]:
Drop the sm6375-tsens and qcm2290-tsens related bindings
fix as it is already posted
Remove unnecessary changes from previous version
[v3]:
Fix make DT_CHECKER_FLAGS=-m dt_binding_check and make dtbs_check errors
[v2]:
Drop the driver change (https://lore.kernel.org/lkml/b45d33d38a334aabbd52c83b0d6028af1f4c74c8.1682682753.git.quic_varada@quicinc.com/)
since the tsens device is compatible with 8074's tsens
and use 8074's compatible itself
Rename clusterX nodes as cpussX
[v1]:
Fix DT node names
[v0]:
Initial patch introducing TSENS support
Praveenkumar I (1):
dt-bindings: thermal: tsens: Add ipq9574 compatible
Varadarajan Narayanan (2):
arm64: dts: qcom: ipq9574: add tsens node
arm64: dts: qcom: ipq9574: add thermal zone nodes
.../devicetree/bindings/thermal/qcom-tsens.yaml | 11 +-
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 217 +++++++++++++++++++++
2 files changed, 226 insertions(+), 2 deletions(-)
--
2.7.4
IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures
around the various subsystems on the die.
Co-developed-by: Praveenkumar I <[email protected]>
Signed-off-by: Praveenkumar I <[email protected]>
Signed-off-by: Varadarajan Narayanan <[email protected]>
---
[v2]:
Add "qcom,ipq8074-tsens" as fallback compatible
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 0ab5556..15c9447 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -958,6 +958,15 @@
status = "disabled";
};
+ tsens: thermal-sensor@4a9000 {
+ compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens";
+ reg = <0x4a9000 0x1000>, /* TM */
+ <0x4a8000 0x1000>; /* SROT */
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "combined";
+ #qcom,sensors = <16>;
+ #thermal-sensor-cells = <1>;
+ };
};
timer {
--
2.7.4
From: Praveenkumar I <[email protected]>
Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
Signed-off-by: Praveenkumar I <[email protected]>
Signed-off-by: Varadarajan Narayanan <[email protected]>
---
[v4]:
Add description about IPQ9574 and remove unnecessary
additions to the file
[v3]:
Fix dt_binding_check & dtbs_check errors (Used
Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
as reference/example)
Drop 'Acked-by: Rob Herring' as suggested in review
[v2]:
Thanks to Krzysztof Kozlowski <[email protected]>
for the tip to make qcom,ipq8074-tsens as fallback.
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index d1ec963..1a752e0 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -16,9 +16,14 @@ description: |
The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures
everything before v1 when there was no versioning information.
+ Since IPQ9574 is similar to IPQ8074, mapping it to IPQ8074 without
+ introducing a new compatible.
+
properties:
compatible:
oneOf:
+ - const: qcom,ipq8074-tsens
+
- description: msm8960 TSENS based
items:
- enum:
@@ -64,8 +69,10 @@ properties:
- const: qcom,tsens-v2
- description: v2 of TSENS with combined interrupt
- enum:
- - qcom,ipq8074-tsens
+ items:
+ - enum:
+ - qcom,ipq9574-tsens
+ - const: qcom,ipq8074-tsens
reg:
items:
--
2.7.4
On Wed, May 24, 2023 at 03:06:09PM +0530, Varadarajan Narayanan wrote:
> From: Praveenkumar I <[email protected]>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Signed-off-by: Praveenkumar I <[email protected]>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> [v4]:
> Add description about IPQ9574 and remove unnecessary
> additions to the file
> [v3]:
> Fix dt_binding_check & dtbs_check errors (Used
> Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> as reference/example)
>
> Drop 'Acked-by: Rob Herring' as suggested in review
>
> [v2]:
> Thanks to Krzysztof Kozlowski <[email protected]>
> for the tip to make qcom,ipq8074-tsens as fallback.
Thanks for re-sending. I'm going to "ignore" this patch & Krzysztof can
take a look at it next week.
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..1a752e0 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -16,9 +16,14 @@ description: |
> The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures
> everything before v1 when there was no versioning information.
>
> + Since IPQ9574 is similar to IPQ8074, mapping it to IPQ8074 without
> + introducing a new compatible.
> +
> properties:
> compatible:
> oneOf:
> + - const: qcom,ipq8074-tsens
> +
> - description: msm8960 TSENS based
> items:
> - enum:
> @@ -64,8 +69,10 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
> + items:
> + - enum:
> + - qcom,ipq9574-tsens
> + - const: qcom,ipq8074-tsens
>
> reg:
> items:
> --
> 2.7.4
>
On Wed, May 24, 2023 at 03:06:10PM +0530, Varadarajan Narayanan wrote:
> IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures
> around the various subsystems on the die.
>
> Co-developed-by: Praveenkumar I <[email protected]>
> Signed-off-by: Praveenkumar I <[email protected]>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> [v2]:
> Add "qcom,ipq8074-tsens" as fallback compatible
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 0ab5556..15c9447 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -958,6 +958,15 @@
> status = "disabled";
> };
>
> + tsens: thermal-sensor@4a9000 {
> + compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens";
> + reg = <0x4a9000 0x1000>, /* TM */
Please pad addresses to 8 digits, and sort nodes by address.
Regards,
Bjorn
> + <0x4a8000 0x1000>; /* SROT */
> + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "combined";
> + #qcom,sensors = <16>;
> + #thermal-sensor-cells = <1>;
> + };
> };
>
> timer {
> --
> 2.7.4
>
On 24/05/2023 11:36, Varadarajan Narayanan wrote:
> From: Praveenkumar I <[email protected]>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Signed-off-by: Praveenkumar I <[email protected]>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> [v4]:
> Add description about IPQ9574 and remove unnecessary
> additions to the file
> [v3]:
> Fix dt_binding_check & dtbs_check errors (Used
> Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> as reference/example)
>
> Drop 'Acked-by: Rob Herring' as suggested in review
>
> [v2]:
> Thanks to Krzysztof Kozlowski <[email protected]>
> for the tip to make qcom,ipq8074-tsens as fallback.
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..1a752e0 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -16,9 +16,14 @@ description: |
> The IP versions are named v0.1, v1 and v2 in the driver, where v0.1 captures
> everything before v1 when there was no versioning information.
>
> + Since IPQ9574 is similar to IPQ8074, mapping it to IPQ8074 without
> + introducing a new compatible.
> +
> properties:
> compatible:
> oneOf:
> + - const: qcom,ipq8074-tsens
No, no need to move it to const. Was correct before.
> +
> - description: msm8960 TSENS based
> items:
> - enum:
> @@ -64,8 +69,10 @@ properties:
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
> - enum:
> - - qcom,ipq8074-tsens
Again, "-" means you remove a diff hunk. `man diff` and `man patch` (or
Wikipedia, dunno).
> + items:
> + - enum:
> + - qcom,ipq9574-tsens
> + - const: qcom,ipq8074-tsens
No, do not touch existing entry.
You need new item on entire list with two compatibles:
+ items:
+ - enum:
+ - qcom,ipq9574-tsens
+ - const: qcom,ipq8074-tsens
That's it. There should be no removal hunks in your diff (so one with "-").
Best regards,
Krzysztof
On Wed, 24 May 2023 15:06:08 +0530, Varadarajan Narayanan wrote:
> This patch set enables tsens in IPQ9574
>
> Depends on
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> [v4]:
> Drop the sm6375-tsens and qcm2290-tsens related bindings
> fix as it is already posted
>
> [...]
Applied, thanks!
[2/3] arm64: dts: qcom: ipq9574: add tsens node
commit: 2e0580e10e919b544d7be1b2b8fc48fc7dff1322
[3/3] arm64: dts: qcom: ipq9574: add thermal zone nodes
commit: 581dcbe60b6390c633f318a29db41d1df642e6d8
Best regards,
--
Bjorn Andersson <[email protected]>