2023-05-25 12:59:54

by Claudiu Beznea

[permalink] [raw]
Subject: [PATCH 4/5] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert to yaml

Convert Atmel AT91RM9200 system timer watchdog bindings to YAML.

Signed-off-by: Claudiu Beznea <[email protected]>
---
.../watchdog/atmel,at91rm9200-wdt.yaml | 29 +++++++++++++++++++
.../watchdog/atmel-at91rm9200-wdt.txt | 9 ------
2 files changed, 29 insertions(+), 9 deletions(-)
create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
new file mode 100644
index 000000000000..d05cdf15dc1c
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
@@ -0,0 +1,29 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/atmel,at91rm9200-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel AT91RM9200 System Timer Watchdog
+
+maintainers:
+ - Nicolas Ferre <[email protected]>
+ - Alexandre Belloni <[email protected]>
+ - Claudiu Beznea <[email protected]>
+
+properties:
+ compatible:
+ const: atmel,at91rm9200-wdt
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ watchdog {
+ compatible = "atmel,at91rm9200-wdt";
+ }
+
+...
diff --git a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
deleted file mode 100644
index d4d86cf8f9eb..000000000000
--- a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
+++ /dev/null
@@ -1,9 +0,0 @@
-Atmel AT91RM9200 System Timer Watchdog
-
-Required properties:
-- compatible: must be "atmel,at91sam9260-wdt".
-
-Example:
- watchdog@fffffd00 {
- compatible = "atmel,at91rm9200-wdt";
- };
--
2.34.1



2023-05-25 17:21:36

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 4/5] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert to yaml

On Thu, May 25, 2023 at 03:56:01PM +0300, Claudiu Beznea wrote:
> Convert Atmel AT91RM9200 system timer watchdog bindings to YAML.
>
> Signed-off-by: Claudiu Beznea <[email protected]>
> ---
> .../watchdog/atmel,at91rm9200-wdt.yaml | 29 +++++++++++++++++++
> .../watchdog/atmel-at91rm9200-wdt.txt | 9 ------
> 2 files changed, 29 insertions(+), 9 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> new file mode 100644
> index 000000000000..d05cdf15dc1c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/atmel,at91rm9200-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel AT91RM9200 System Timer Watchdog
> +
> +maintainers:
> + - Nicolas Ferre <[email protected]>
> + - Alexandre Belloni <[email protected]>
> + - Claudiu Beznea <[email protected]>
> +
> +properties:
> + compatible:
> + const: atmel,at91rm9200-wdt
> +
> +required:
> + - compatible
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + watchdog {
> + compatible = "atmel,at91rm9200-wdt";
> + }

This example is broken, you missed copying the ;

Thanks,
Conor.

> +
> +...
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
> deleted file mode 100644
> index d4d86cf8f9eb..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -Atmel AT91RM9200 System Timer Watchdog
> -
> -Required properties:
> -- compatible: must be "atmel,at91sam9260-wdt".
> -
> -Example:
> - watchdog@fffffd00 {
> - compatible = "atmel,at91rm9200-wdt";
> - };
> --
> 2.34.1
>


Attachments:
(No filename) (2.24 kB)
signature.asc (235.00 B)
Download all attachments

2023-05-26 01:50:55

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 4/5] dt-bindings: watchdog: atmel,at91rm9200-wdt: convert to yaml


On Thu, 25 May 2023 15:56:01 +0300, Claudiu Beznea wrote:
> Convert Atmel AT91RM9200 system timer watchdog bindings to YAML.
>
> Signed-off-by: Claudiu Beznea <[email protected]>
> ---
> .../watchdog/atmel,at91rm9200-wdt.yaml | 29 +++++++++++++++++++
> .../watchdog/atmel-at91rm9200-wdt.txt | 9 ------
> 2 files changed, 29 insertions(+), 9 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-at91rm9200-wdt.txt
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.example.dts:22.5-6 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/watchdog/atmel,at91rm9200-wdt.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1512: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.