2023-05-25 16:29:47

by Osama Muhammad

Subject: [PATCH] adm1266.c: Drop error checking for debugfs_create_dir

This patch fixes the error checking in adm1266.c.
The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.

Signed-off-by: Osama Muhammad <[email protected]>
---
drivers/hwmon/pmbus/adm1266.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
index 1ac2b2f4c570..184d75269d2b 100644
--- a/drivers/hwmon/pmbus/adm1266.c
+++ b/drivers/hwmon/pmbus/adm1266.c
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
return;

data->debugfs_dir = debugfs_create_dir(data->client->name, root);
- if (!data->debugfs_dir)
- return;

debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
adm1266_state_read);
--
2.34.1

2023-05-25 18:18:59

by Guenter Roeck

Subject: Re: [PATCH] adm1266.c: Drop error checking for debugfs_create_dir

On Thu, May 25, 2023 at 09:08:27PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in adm1266.c.
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Osama Muhammad <[email protected]>

Confusing. Is this v3 of the patch ?

Guenter

> ---
> drivers/hwmon/pmbus/adm1266.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 1ac2b2f4c570..184d75269d2b 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
> return;
>
> data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> - if (!data->debugfs_dir)
> - return;
>
> debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
> adm1266_state_read);
> --
> 2.34.1
>

2023-05-25 18:33:57

by Osama Muhammad

Subject: Re: [PATCH] adm1266.c: Drop error checking for debugfs_create_dir

This is the new patch not v3. The patch I sent as v2 was a mistake.
Please discard the patch I sent earlier as v2 .
Apologies for the confusion.Hope it clarifies.

Regards,
Osmten



On Thu, 25 May 2023 at 23:17, Guenter Roeck <[email protected]> wrote:
>
> On Thu, May 25, 2023 at 09:08:27PM +0500, Osama Muhammad wrote:
> > This patch fixes the error checking in adm1266.c.
> > The DebugFS kernel API is developed in
> > a way that the caller can safely ignore the errors that
> > occur during the creation of DebugFS nodes.
> >
> > Signed-off-by: Osama Muhammad <[email protected]>
>
> Confusing. Is this v3 of the patch ?
>
> Guenter
>
> > ---
> > drivers/hwmon/pmbus/adm1266.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> > index 1ac2b2f4c570..184d75269d2b 100644
> > --- a/drivers/hwmon/pmbus/adm1266.c
> > +++ b/drivers/hwmon/pmbus/adm1266.c
> > @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
> > return;
> >
> > data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> > - if (!data->debugfs_dir)
> > - return;
> >
> > debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
> > adm1266_state_read);
> > --
> > 2.34.1
> >