2023-05-27 03:16:47

by Kefeng Wang

Subject: [PATCH] mm/damon/core: fix divide error in damon_nr_accesses_to_accesses_bp()

If 'aggr_interval' is smaller than 'sample_interval', max_nr_accesses becomes
zero which leads to divide error in damon_nr_accesses_to_accesses_bp(), let's
validate the values of them in damon_set_attrs() to fix it, which similar to
others attrs check.

Reported-by: [email protected]
Fixes: 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes")
Signed-off-by: Kefeng Wang <[email protected]>
---
mm/damon/core.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index d9ef62047bf5..91cff7f2997e 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -551,6 +551,8 @@ int damon_set_attrs(struct damon_ctx *ctx, struct damon_attrs *attrs)
return -EINVAL;
if (attrs->min_nr_regions > attrs->max_nr_regions)
return -EINVAL;
+ if (attrs->sample_interval > attrs->aggr_interval)
+ return -EINVAL;

damon_update_monitoring_results(ctx, attrs);
ctx->attrs = *attrs;
--
2.35.3

2023-05-27 03:30:46

by SeongJae Park

Subject: Re: [PATCH] mm/damon/core: fix divide error in damon_nr_accesses_to_accesses_bp()

On Fri, 26 May 2023 19:31:49 -0700 SeongJae Park <[email protected]> wrote:

[...]
> Could you please resolve those by wrapping the commit messages and adding
> 'Closes:' tag? 'Closes:' tag might be able to replace the 'Link:' tag I
> supposed above. I have no strong opinions there but having both may harm

s/supposed/suggested/


Thanks,
SJ

[...]

2023-05-27 03:31:01

by SeongJae Park

Subject: Re: [PATCH] mm/damon/core: fix divide error in damon_nr_accesses_to_accesses_bp()

Hi Kefeng,

Thank you so much for this awesome patch!

On Sat, 27 May 2023 10:33:30 +0800 Kefeng Wang <[email protected]> wrote:

> If 'aggr_interval' is smaller than 'sample_interval', max_nr_accesses becomes
> zero which leads to divide error in damon_nr_accesses_to_accesses_bp(), let's
> validate the values of them in damon_set_attrs() to fix it, which similar to
> others attrs check.
>
> Reported-by: [email protected]

I think it would be good to add the link to the report, e.g.,
"Link: https://lore.kernel.org/damon/[email protected]/"

> Fixes: 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes")

Could you please add 'Cc: <[email protected]> # 6.3.x-' ?

Also, checkpatch.pl raises below warnings.

```
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#61:
If 'aggr_interval' is smaller than 'sample_interval', max_nr_accesses becomes

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#66:
Reported-by: [email protected]
Fixes: 2f5bef5a590b ("mm/damon/core: update monitoring results for new monitoring attributes")

total: 0 errors, 2 warnings, 8 lines checked
```

Could you please resolve those by wrapping the commit messages and adding
'Closes:' tag? 'Closes:' tag might be able to replace the 'Link:' tag I
supposed above. I have no strong opinions there but having both may harm
nothing.

Other than those,

Reviewed-by: SeongJae Park <[email protected]>


Thanks,
SJ

> Signed-off-by: Kefeng Wang <[email protected]>
> ---
> mm/damon/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index d9ef62047bf5..91cff7f2997e 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -551,6 +551,8 @@ int damon_set_attrs(struct damon_ctx *ctx, struct damon_attrs *attrs)
> return -EINVAL;
> if (attrs->min_nr_regions > attrs->max_nr_regions)
> return -EINVAL;
> + if (attrs->sample_interval > attrs->aggr_interval)
> + return -EINVAL;
>
> damon_update_monitoring_results(ctx, attrs);
> ctx->attrs = *attrs;
> --
> 2.35.3
>