2023-05-24 04:04:03

by David Tadokoro

Subject: [PATCH] staging: rtl8192e: Fix BRACES warning

Fix checkpatch warning "braces {} are not necessary for single statement
blocks".

Signed-off-by: David Tadokoro <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 4b0ebe96302e..ea993cbb7bf7 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -1099,9 +1099,8 @@ static bool _rtl92e_set_rf_power_state(struct net_device *dev,
break;
}

- if (bResult) {
+ if (bResult)
priv->rtllib->rf_power_state = rf_power_state;
- }

priv->set_rf_pwr_state_in_progress = false;
return bResult;
--
2.40.1

2023-05-28 10:01:10

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8192e: Fix BRACES warning

On Wed, May 24, 2023 at 01:00:51AM -0300, David Tadokoro wrote:
> Fix checkpatch warning "braces {} are not necessary for single statement
> blocks".

Why do you have "BRACES" in the subject line as all caps? Where did
that term come from?

No need to shout :)

thanks,

greg k-h

2023-05-28 16:07:41

by David Tadokoro

Subject: Re: [PATCH] staging: rtl8192e: Fix BRACES warning

> On 28 May 2023, at 06:10, Greg KH <[email protected]> wrote:
>
> On Wed, May 24, 2023 at 01:00:51AM -0300, David Tadokoro wrote:
>> Fix checkpatch warning "braces {} are not necessary for single statement
>> blocks".
>
> Why do you have "BRACES" in the subject line as all caps? Where did
> that term come from?
>
> No need to shout :)
>
> thanks,
>
> greg k-h

Hi, Greg

Thanks so much for your feedback.

You are right, this commit message is horrible. I based it on
a previous commit that cleaned the same warning instead of writing a good commit message myself. Going to fix that.

Sorry for the mess ;)

Many regards,
David