2023-05-30 08:04:21

by Fabrizio Lamarque

[permalink] [raw]
Subject: [PATCH v3 4/5] dt-bindings: iio: ad7192: Add mandatory reference voltage source

From: Fabrizio Lamarque <[email protected]>

Add required reference voltage (VRef) supply regulator.

AD7192 requires three independent voltage sources: DVdd, AVdd and VRef
(on REFINx pin pairs).

Fixes: b581f748cce0 ("staging: iio: adc: ad7192: move out of staging")
Signed-off-by: Fabrizio Lamarque <[email protected]>
---
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
index d521d516088b..16def2985ab4 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
@@ -47,6 +47,9 @@ properties:
avdd-supply:
description: AVdd voltage supply

+ vref-supply:
+ description: VRef voltage supply
+
adi,rejection-60-Hz-enable:
description: |
This bit enables a notch at 60 Hz when the first notch of the sinc
@@ -89,6 +92,7 @@ required:
- interrupts
- dvdd-supply
- avdd-supply
+ - vref-supply
- spi-cpol
- spi-cpha

@@ -115,6 +119,7 @@ examples:
interrupt-parent = <&gpio>;
dvdd-supply = <&dvdd>;
avdd-supply = <&avdd>;
+ vref-supply = <&vref>;

adi,refin2-pins-enable;
adi,rejection-60-Hz-enable;
--
2.34.1



2023-05-30 17:31:26

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v3 4/5] dt-bindings: iio: ad7192: Add mandatory reference voltage source

On Tue, May 30, 2023 at 09:53:10AM +0200, [email protected] wrote:
> From: Fabrizio Lamarque <[email protected]>
>
> Add required reference voltage (VRef) supply regulator.
>
> AD7192 requires three independent voltage sources: DVdd, AVdd and VRef
> (on REFINx pin pairs).
>
> Fixes: b581f748cce0 ("staging: iio: adc: ad7192: move out of staging")
> Signed-off-by: Fabrizio Lamarque <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

Attachments:
(No filename) (508.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-06-04 12:18:03

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v3 4/5] dt-bindings: iio: ad7192: Add mandatory reference voltage source

On Tue, 30 May 2023 18:22:45 +0100
Conor Dooley <[email protected]> wrote:

> On Tue, May 30, 2023 at 09:53:10AM +0200, [email protected] wrote:
> > From: Fabrizio Lamarque <[email protected]>
> >
> > Add required reference voltage (VRef) supply regulator.
> >
> > AD7192 requires three independent voltage sources: DVdd, AVdd and VRef
> > (on REFINx pin pairs).
> >
> > Fixes: b581f748cce0 ("staging: iio: adc: ad7192: move out of staging")
> > Signed-off-by: Fabrizio Lamarque <[email protected]>
>
> Acked-by: Conor Dooley <[email protected]>
Applied.

I'll leave 3 and 5 for a v4 posting.
>
> Thanks,
> Conor.