NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
configures parallel display format by using the "PARALLEL_DISP_FORMAT"
field. Add device tree bindings for the display format configuration.
Signed-off-by: Liu Ying <[email protected]>
---
v1->v2:
* No change.
.../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++
1 file changed, 78 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml
diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml
new file mode 100644
index 000000000000..a84bfb46b01d
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/nxp,imx93-pdfc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX93 Parallel Display Format Configuration
+
+maintainers:
+ - Liu Ying <[email protected]>
+
+description: |
+ The i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
+ configures parallel display format by using the "PARALLEL_DISP_FORMAT"
+ field.
+
+properties:
+ compatible:
+ const: nxp,imx93-pdfc
+
+ reg:
+ maxItems: 1
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Input port node to receive pixel data.
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Output port node to downstream pixel data receivers.
+
+ required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+
+ blk-ctrl {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ bridge@60 {
+ compatible = "nxp,imx93-pdfc";
+ reg = <0x60 0x4>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ pdfc_from_lcdif: endpoint {
+ remote-endpoint = <&lcdif_to_pdfc>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ pdfc_to_panel: endpoint {
+ remote-endpoint = <&panel_from_pdfc>;
+ };
+ };
+ };
+ };
+ };
--
2.37.1
On 31/05/2023 11:32, Liu Ying wrote:
> NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
> configures parallel display format by using the "PARALLEL_DISP_FORMAT"
> field. Add device tree bindings for the display format configuration.
>
> Signed-off-by: Liu Ying <[email protected]>
> ---
> v1->v2:
> * No change.
How did you implement Rob's comment?
>
> .../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml
>
Best regards,
Krzysztof
On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 31/05/2023 11:32, Liu Ying wrote:
> > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
> > configures parallel display format by using the "PARALLEL_DISP_FORMAT"
> > field. Add device tree bindings for the display format configuration.
> >
> > Signed-off-by: Liu Ying <[email protected]>
> > ---
> > v1->v2:
> > * No change.
>
> How did you implement Rob's comment?
Should have discussed more in v1 about Rob's comment, but
let me explain why this dt-binding makes sense here:
Both i.MX8mp SoC and i.MX93 SoC media block control devices
contain a LVDS Display Bridge(LDB) child device. The i.MX93 block
control device additionally contains this PDFC child device.
LDB dt-binding [1] is written in a separate file and referenced in
i.MX8mp block control dt-binding [2]. So, for the sake of consistency,
it makes sense to keep this PDFC dt-binding and reference it
together with the LDB one [1] in i.MX93 block control dt-binding [3]
in future, doesn't it?
It seems good to have a separate PDFC dt-binding in case it can/will
be referenced by multiple parent device dt-bindings.
[1] Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
[2] Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
[3] Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
Regards,
Liu Ying
>
> >
> > .../display/bridge/nxp,imx93-pdfc.yaml | 78 +++++++++++++++++++
> > 1 file changed, 78 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,imx93-pdfc.yaml
On 02/06/2023 05:54, Ying Liu wrote:
> On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 31/05/2023 11:32, Liu Ying wrote:
>>> NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
>>> configures parallel display format by using the "PARALLEL_DISP_FORMAT"
>>> field. Add device tree bindings for the display format configuration.
>>>
>>> Signed-off-by: Liu Ying <[email protected]>
>>> ---
>>> v1->v2:
>>> * No change.
>>
>> How did you implement Rob's comment?
>
> Should have discussed more in v1 about Rob's comment, but
> let me explain why this dt-binding makes sense here:
"It needs to be defined as part of the mediamix blkctrl
schema though."
Where is it defined in mediamix blkctrl?
Best regards,
Krzysztof
On Sun, Jun 4, 2023 at 6:16 PM Krzysztof Kozlowski
<[email protected]> wrote:
> On 02/06/2023 05:54, Ying Liu wrote:
> > On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski
> > <[email protected]> wrote:
> >>
> >> On 31/05/2023 11:32, Liu Ying wrote:
> >>> NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which
> >>> configures parallel display format by using the "PARALLEL_DISP_FORMAT"
> >>> field. Add device tree bindings for the display format configuration.
> >>>
> >>> Signed-off-by: Liu Ying <[email protected]>
> >>> ---
> >>> v1->v2:
> >>> * No change.
> >>
> >> How did you implement Rob's comment?
> >
> > Should have discussed more in v1 about Rob's comment, but
> > let me explain why this dt-binding makes sense here:
>
> "It needs to be defined as part of the mediamix blkctrl
> schema though."
>
> Where is it defined in mediamix blkctrl?
I've sent v3 patch set out to define it in mediamix blk-ctrl.
Regards,
Liu Ying