2023-06-01 03:34:10

by Jiasheng Jiang

[permalink] [raw]
Subject: [PATCH] net: systemport: Replace platform_get_irq with platform_get_irq_optional

Replace platform_get_irq with platform_get_irq_optional because wol_irq
is optional.

Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 38d0cdaf22a5..bf1611cce974 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2531,9 +2531,9 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->irq0 = platform_get_irq(pdev, 0);
if (!priv->is_lite) {
priv->irq1 = platform_get_irq(pdev, 1);
- priv->wol_irq = platform_get_irq(pdev, 2);
+ priv->wol_irq = platform_get_irq_optional(pdev, 2);
} else {
- priv->wol_irq = platform_get_irq(pdev, 1);
+ priv->wol_irq = platform_get_irq_optional(pdev, 1);
}
if (priv->irq0 <= 0 || (priv->irq1 <= 0 && !priv->is_lite)) {
ret = -EINVAL;
--
2.25.1



2023-06-01 17:58:55

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH] net: systemport: Replace platform_get_irq with platform_get_irq_optional

On 5/31/23 20:30, Jiasheng Jiang wrote:
> Replace platform_get_irq with platform_get_irq_optional because wol_irq
> is optional.
>
> Signed-off-by: Jiasheng Jiang <[email protected]>

I suppose this works as far as communicating the intent and the nature
of the interrupt, not that this is a functional change though:

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2023-06-02 09:04:29

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: systemport: Replace platform_get_irq with platform_get_irq_optional

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Thu, 1 Jun 2023 11:30:02 +0800 you wrote:
> Replace platform_get_irq with platform_get_irq_optional because wol_irq
> is optional.
>
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> drivers/net/ethernet/broadcom/bcmsysport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- net: systemport: Replace platform_get_irq with platform_get_irq_optional
https://git.kernel.org/netdev/net/c/f93b30e50a81

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html