2023-06-01 21:10:02

by Bhatnagar, Rishabh

[permalink] [raw]
Subject: [PATCH 5.4 1/2] cifs: get rid of unused parameter in reconn_setup_dfs_targets()

From: Paulo Alcantara <[email protected]>

commit baf3f08ef4083b76ca67b143e135213a7f941879 upstream.

The target iterator parameter "it" is not used in
reconn_setup_dfs_targets(), so just remove it.

Signed-off-by: Paulo Alcantara (SUSE) <[email protected]>
Reviewed-by: Aurelien Aptel <[email protected]>
Signed-off-by: Steve French <[email protected]>
---
fs/cifs/connect.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 6c8dd7c0b83a..b5cd3dc479ce 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -469,8 +469,7 @@ static void reconn_inval_dfs_target(struct TCP_Server_Info *server,
}

static inline int reconn_setup_dfs_targets(struct cifs_sb_info *cifs_sb,
- struct dfs_cache_tgt_list *tl,
- struct dfs_cache_tgt_iterator **it)
+ struct dfs_cache_tgt_list *tl)
{
if (!cifs_sb->origin_fullpath)
return -EOPNOTSUPP;
@@ -515,7 +514,7 @@ cifs_reconnect(struct TCP_Server_Info *server)
} else {
cifs_sb = CIFS_SB(sb);

- rc = reconn_setup_dfs_targets(cifs_sb, &tgt_list, &tgt_it);
+ rc = reconn_setup_dfs_targets(cifs_sb, &tgt_list);
if (rc && (rc != -EOPNOTSUPP)) {
cifs_server_dbg(VFS, "%s: no target servers for DFS failover\n",
__func__);
--
2.39.2



2023-06-07 18:23:00

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 1/2] cifs: get rid of unused parameter in reconn_setup_dfs_targets()

On Thu, Jun 01, 2023 at 08:58:16PM +0000, Rishabh Bhatnagar wrote:
> From: Paulo Alcantara <[email protected]>
>
> commit baf3f08ef4083b76ca67b143e135213a7f941879 upstream.
>
> The target iterator parameter "it" is not used in
> reconn_setup_dfs_targets(), so just remove it.
>
> Signed-off-by: Paulo Alcantara (SUSE) <[email protected]>
> Reviewed-by: Aurelien Aptel <[email protected]>
> Signed-off-by: Steve French <[email protected]>
> ---

When passing on patches from other people, you too have to sign-off on
the patch, saying that you are ok with it.

Please resend this series with your signed-off on it as well (after
reading the documentation to understand what you are agreeing to.)

thanks,

greg k-h