2023-06-01 21:39:08

by Arnd Bergmann

Subject: [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static

From: Arnd Bergmann <[email protected]>

This was apparently made global but is not called from anywhere else:

drivers/leds/leds-cht-wcove.c:144:21: error: no previous prototype for 'cht_wc_leds_brightness_get' [-Werror=missing-prototypes]

Fixes: 047da762b9a93 ("leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/leds/leds-cht-wcove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 0cfebee989107..0a5c30e5ed5d4 100644
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
return ret;
}

-enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
+static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
{
struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
unsigned int val;
--
2.39.2

2023-06-02 13:12:06

by Hans de Goede

Subject: Re: [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static

Hi Arnd,

On 6/1/23 23:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> This was apparently made global but is not called from anywhere else:
>
> drivers/leds/leds-cht-wcove.c:144:21: error: no previous prototype for 'cht_wc_leds_brightness_get' [-Werror=missing-prototypes]
>
> Fixes: 047da762b9a93 ("leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thank you for the patch. This is a duplicate fix with these
2 earlier submissions of the same fix:

https://lore.kernel.org/linux-leds/[email protected]/
https://lore.kernel.org/linux-leds/[email protected]/

Regards,

Hans





> ---
> drivers/leds/leds-cht-wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
> index 0cfebee989107..0a5c30e5ed5d4 100644
> --- a/drivers/leds/leds-cht-wcove.c
> +++ b/drivers/leds/leds-cht-wcove.c
> @@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
> return ret;
> }
>
> -enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
> +static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
> {
> struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
> unsigned int val;