2023-06-02 09:23:30

by Yang Li

Subject: [PATCH -next] drm/meson: Remove unneeded semicolon

./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
index dd505ac37976..57447abf1a29 100644
--- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
+++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
@@ -114,7 +114,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
case MIPI_DSI_FMT_RGB666_PACKED:
case MIPI_DSI_FMT_RGB565:
return -EINVAL;
- };
+ }

/* Configure color format for DPI register */
writel_relaxed(FIELD_PREP(MIPI_DSI_TOP_DPI_COLOR_MODE, dpi_data_format) |
@@ -228,7 +228,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
case MIPI_DSI_FMT_RGB565:
dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
return -EINVAL;
- };
+ }

ret = phy_init(mipi_dsi->phy);
if (ret)
--
2.20.1.7.g153144c

2023-06-02 09:48:48

by Neil Armstrong

Subject: Re: [PATCH -next] drm/meson: Remove unneeded semicolon

On 02/06/2023 11:14, Yang Li wrote:
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> index dd505ac37976..57447abf1a29 100644
> --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> @@ -114,7 +114,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
> case MIPI_DSI_FMT_RGB666_PACKED:
> case MIPI_DSI_FMT_RGB565:
> return -EINVAL;
> - };
> + }
>
> /* Configure color format for DPI register */
> writel_relaxed(FIELD_PREP(MIPI_DSI_TOP_DPI_COLOR_MODE, dpi_data_format) |
> @@ -228,7 +228,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
> case MIPI_DSI_FMT_RGB565:
> dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
> return -EINVAL;
> - };
> + }
>
> ret = phy_init(mipi_dsi->phy);
> if (ret)

Acked-by: Neil Armstrong <[email protected]>

2023-06-02 14:12:08

by Neil Armstrong

Subject: Re: [PATCH -next] drm/meson: Remove unneeded semicolon

Hi,

On Fri, 02 Jun 2023 17:14:16 +0800, Yang Li wrote:
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon
> ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon
>
>

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/meson: Remove unneeded semicolon
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=e96f099c8544a542f7cd37d2e51ba52786adbbc7

--
Neil