2023-06-02 12:55:27

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG

From: Arnd Bergmann <[email protected]>

The vangogh driver just gained a link time dependency that now causes
randconfig builds to fail:

x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function `snd_acp5x_probe':
pci-acp5x.c:(.text+0xbb): undefined reference to `snd_amd_acp_find_config'

Fixes: e89f45edb747e ("ASoC: amd: vangogh: Add check for acp config flags in vangogh platform")
Signed-off-by: Arnd Bergmann <[email protected]>
---
sound/soc/amd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 08e42082f5e96..e724cb3c70b74 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -81,6 +81,7 @@ config SND_SOC_AMD_VANGOGH_MACH
tristate "AMD Vangogh support for NAU8821 CS35L41"
select SND_SOC_NAU8821
select SND_SOC_CS35L41_SPI
+ select SND_AMD_ACP_CONFIG
depends on SND_SOC_AMD_ACP5x && I2C && SPI_MASTER
help
This option enables machine driver for Vangogh platform
--
2.39.2



2023-06-05 09:18:06

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG

On Fri, Jun 2, 2023, at 14:44, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The vangogh driver just gained a link time dependency that now causes
> randconfig builds to fail:
>
> x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function
> `snd_acp5x_probe':
> pci-acp5x.c:(.text+0xbb): undefined reference to
> `snd_amd_acp_find_config'
>
> Fixes: e89f45edb747e ("ASoC: amd: vangogh: Add check for acp config
> flags in vangogh platform")
> Signed-off-by: Arnd Bergmann <[email protected]>

Please disregard, this version was incomplete, and I ran into the
same issue again in another randconfig build.

v2 coming up, please use that instead.

2023-06-05 12:30:18

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG

On Fri, 02 Jun 2023 14:44:39 +0200, Arnd Bergmann wrote:
> The vangogh driver just gained a link time dependency that now causes
> randconfig builds to fail:
>
> x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function `snd_acp5x_probe':
> pci-acp5x.c:(.text+0xbb): undefined reference to `snd_amd_acp_find_config'
>
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG
commit: 812a05256d673b2b9c5db906775d1e6625ba4787

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


2023-06-05 12:50:52

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG

On Mon, Jun 05, 2023 at 10:58:25AM +0200, Arnd Bergmann wrote:

> Please disregard, this version was incomplete, and I ran into the
> same issue again in another randconfig build.

> v2 coming up, please use that instead.

I already applied this one before I saw your message...


Attachments:
(No filename) (287.00 B)
signature.asc (499.00 B)
Download all attachments