2023-06-02 13:13:18

by Arnd Bergmann

Subject: [PATCH] drm/meson: venc: include linux/bitfield.h

From: Arnd Bergmann <[email protected]>

Without this header, the use of FIELD_PREP() can cause a build failure:

drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]

Fixes: 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpu/drm/meson/meson_venc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
index 2bdc2855e249b..3bf0d6e4fc30a 100644
--- a/drivers/gpu/drm/meson/meson_venc.c
+++ b/drivers/gpu/drm/meson/meson_venc.c
@@ -5,6 +5,7 @@
* Copyright (C) 2015 Amlogic, Inc. All rights reserved.
*/

+#include <linux/bitfield.h>
#include <linux/export.h>
#include <linux/iopoll.h>

--
2.39.2

2023-06-02 13:53:37

by Neil Armstrong

Subject: Re: [PATCH] drm/meson: venc: include linux/bitfield.h

On 02/06/2023 14:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Without this header, the use of FIELD_PREP() can cause a build failure:
>
> drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
> drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>
> Fixes: 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 2bdc2855e249b..3bf0d6e4fc30a 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -5,6 +5,7 @@
> * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
> */
>
> +#include <linux/bitfield.h>
> #include <linux/export.h>
> #include <linux/iopoll.h>
>

Acked-by: Neil Armstrong <[email protected]>

2023-06-02 14:12:34

by Neil Armstrong

Subject: Re: [PATCH] drm/meson: venc: include linux/bitfield.h

Hi,

On Fri, 02 Jun 2023 14:45:24 +0200, Arnd Bergmann wrote:
> Without this header, the use of FIELD_PREP() can cause a build failure:
>
> drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
> drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>
>

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/meson: venc: include linux/bitfield.h
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=664dba662cb313da9cbb1c944c472638a65c552e

--
Neil