LinuxLists.cc - [PATCH] accel/ivpu: ivpu_ipc needs GENERIC

2023-05-26 05:18:46

Subject: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

Drivers that use the gen_pool*() family of functions should
select GENERIC_ALLOCATOR to prevent build errors like these:

ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'

Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Cc: Oded Gabbay <[email protected]>
Cc: [email protected]
Cc: Jacek Lawrynowicz <[email protected]>
Cc: Stanislaw Gruszka <[email protected]>
Cc: Andrzej Kacprowski <[email protected]>
Cc: Krystian Pradzynski <[email protected]>
Cc: Jeffrey Hugo <[email protected]>
Cc: Daniel Vetter <[email protected]>
---
drivers/accel/ivpu/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig
--- a/drivers/accel/ivpu/Kconfig
+++ b/drivers/accel/ivpu/Kconfig
@@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU
depends on PCI && PCI_MSI
select FW_LOADER
select SHMEM
+ select GENERIC_ALLOCATOR
help
Choose this option if you have a system that has an 14th generation Intel CPU
or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated

2023-05-26 07:47:52

by Stanislaw Gruszka

[permalink] [raw]

Subject: Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

On Thu, May 25, 2023 at 09:45:19PM -0700, Randy Dunlap wrote:
> Drivers that use the gen_pool*() family of functions should
> select GENERIC_ALLOCATOR to prevent build errors like these:
>
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
> include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
> drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
> include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
>
> Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]/
> Cc: Oded Gabbay <[email protected]>
> Cc: [email protected]
> Cc: Jacek Lawrynowicz <[email protected]>
> Cc: Stanislaw Gruszka <[email protected]>
> Cc: Andrzej Kacprowski <[email protected]>
> Cc: Krystian Pradzynski <[email protected]>
> Cc: Jeffrey Hugo <[email protected]>
> Cc: Daniel Vetter <[email protected]>
Acked-by: Stanislaw Gruszka <[email protected]>

> ---
> drivers/accel/ivpu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/accel/ivpu/Kconfig b/drivers/accel/ivpu/Kconfig
> --- a/drivers/accel/ivpu/Kconfig
> +++ b/drivers/accel/ivpu/Kconfig
> @@ -7,6 +7,7 @@ config DRM_ACCEL_IVPU
> depends on PCI && PCI_MSI
> select FW_LOADER
> select SHMEM
> + select GENERIC_ALLOCATOR
> help
> Choose this option if you have a system that has an 14th generation Intel CPU
> or newer. VPU stands for Versatile Processing Unit and it's a CPU-integrated

2023-06-02 17:35:28

by Jeffrey Hugo

[permalink] [raw]

Subject: Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

On 5/25/2023 10:45 PM, Randy Dunlap wrote:
> Drivers that use the gen_pool*() family of functions should
> select GENERIC_ALLOCATOR to prevent build errors like these:
>
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_alloc_algo':
> include/linux/genalloc.h:138: undefined reference to `gen_pool_alloc_algo_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free':
> include/linux/genalloc.h:172: undefined reference to `gen_pool_free_owner'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `ivpu_ipc_init':
> drivers/accel/ivpu/ivpu_ipc.c:441: undefined reference to `devm_gen_pool_create'
> ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_add_virt':
> include/linux/genalloc.h:104: undefined reference to `gen_pool_add_owner'
>
> Fixes: 5d7422cfb498 ("accel/ivpu: Add IPC driver and JSM messages")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]/
> Cc: Oded Gabbay <[email protected]>
> Cc: [email protected]
> Cc: Jacek Lawrynowicz <[email protected]>
> Cc: Stanislaw Gruszka <[email protected]>
> Cc: Andrzej Kacprowski <[email protected]>
> Cc: Krystian Pradzynski <[email protected]>
> Cc: Jeffrey Hugo <[email protected]>
> Cc: Daniel Vetter <[email protected]>

Reviewed-by: Jeffrey Hugo <[email protected]>

2023-06-06 12:42:19

by Stanislaw Gruszka

[permalink] [raw]