2023-06-07 05:41:11

by Mahapatra, Amit Kumar

Subject: [PATCH] Revert "mtd: rawnand: arasan: Prevent an unsupported configuration"

This reverts commit fc9e18f9e987ad46722dad53adab1c12148c213c.

This patch was a work around to fix timeout issue while operating in NVDDR
mode with software ECC engine. This patch prevents the Arasan NAND driver
from operating in NVDDR mode with software ECC engine resulting in a
significant performance degradation with SW-ECC.
'commit 7499bfeedb47 ("mtd: rawnand: arasan: Update NAND bus clock instead
of system clock")' and 'commit e16eceea863b ("mtd: rawnand: arasan: Fix
clock rate in NV-DDR")'
fixes the timeout issue in NVDDR mode with SW-ECC so, reverting the changes
as this work around is no longer required.

Signed-off-by: Amit Kumar Mahapatra <[email protected]>
---
BRANCH: nand/next
---
drivers/mtd/nand/raw/arasan-nand-controller.c | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/drivers/mtd/nand/raw/arasan-nand-controller.c b/drivers/mtd/nand/raw/arasan-nand-controller.c
index d513d2db3549..906eef70cb6d 100644
--- a/drivers/mtd/nand/raw/arasan-nand-controller.c
+++ b/drivers/mtd/nand/raw/arasan-nand-controller.c
@@ -973,21 +973,6 @@ static int anfc_setup_interface(struct nand_chip *chip, int target,
nvddr = nand_get_nvddr_timings(conf);
if (IS_ERR(nvddr))
return PTR_ERR(nvddr);
-
- /*
- * The controller only supports data payload requests which are
- * a multiple of 4. In practice, most data accesses are 4-byte
- * aligned and this is not an issue. However, rounding up will
- * simply be refused by the controller if we reached the end of
- * the device *and* we are using the NV-DDR interface(!). In
- * this situation, unaligned data requests ending at the device
- * boundary will confuse the controller and cannot be performed.
- *
- * This is something that happens in nand_read_subpage() when
- * selecting software ECC support and must be avoided.
- */
- if (chip->ecc.engine_type == NAND_ECC_ENGINE_TYPE_SOFT)
- return -ENOTSUPP;
} else {
sdr = nand_get_sdr_timings(conf);
if (IS_ERR(sdr))
--
2.17.1

2023-06-09 15:33:41

by Miquel Raynal

Subject: Re: [PATCH] Revert "mtd: rawnand: arasan: Prevent an unsupported configuration"

On Wed, 2023-06-07 at 05:39:36 UTC, Amit Kumar Mahapatra wrote:
> This reverts commit fc9e18f9e987ad46722dad53adab1c12148c213c.
>
> This patch was a work around to fix timeout issue while operating in NVDDR
> mode with software ECC engine. This patch prevents the Arasan NAND driver
> from operating in NVDDR mode with software ECC engine resulting in a
> significant performance degradation with SW-ECC.
> 'commit 7499bfeedb47 ("mtd: rawnand: arasan: Update NAND bus clock instead
> of system clock")' and 'commit e16eceea863b ("mtd: rawnand: arasan: Fix
> clock rate in NV-DDR")'
> fixes the timeout issue in NVDDR mode with SW-ECC so, reverting the changes
> as this work around is no longer required.
>
> Signed-off-by: Amit Kumar Mahapatra <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel