2023-06-08 09:43:42

by Jiapeng Chong

Subject: [PATCH] tools: ynl: Remove duplicate include

./tools/net/ynl/generated/netdev-user.c: stdlib.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5466
Signed-off-by: Jiapeng Chong <[email protected]>
---
tools/net/ynl/generated/netdev-user.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/net/ynl/generated/netdev-user.c b/tools/net/ynl/generated/netdev-user.c
index aea5c7cc8ead..1883a658180b 100644
--- a/tools/net/ynl/generated/netdev-user.c
+++ b/tools/net/ynl/generated/netdev-user.c
@@ -8,7 +8,6 @@
#include "ynl.h"
#include <linux/netdev.h>

-#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <libmnl/libmnl.h>
--
2.20.1.7.g153144c

2023-06-08 12:23:45

by Simon Horman

Subject: Re: [PATCH] tools: ynl: Remove duplicate include

On Thu, Jun 08, 2023 at 05:30:36PM +0800, Jiapeng Chong wrote:
> ./tools/net/ynl/generated/netdev-user.c: stdlib.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5466
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> tools/net/ynl/generated/netdev-user.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/net/ynl/generated/netdev-user.c b/tools/net/ynl/generated/netdev-user.c
> index aea5c7cc8ead..1883a658180b 100644
> --- a/tools/net/ynl/generated/netdev-user.c
> +++ b/tools/net/ynl/generated/netdev-user.c
> @@ -8,7 +8,6 @@
> #include "ynl.h"
> #include <linux/netdev.h>
>
> -#include <stdlib.h>
> #include <stdio.h>
> #include <string.h>
> #include <libmnl/libmnl.h>

This duplicates:

- [PATCH -next] tools: ynl: Remove duplicated include in handshake-user.c
https://lore.kernel.org/all/[email protected]/

So lets focus on that one.

In all three very similar patches were sent in a short space of time.
It's better not to do that.

--
pw-bot: reject