2023-06-02 06:37:40

by Sean Nyekjaer

Subject: [PATCH v3 2/2] mfd: stpmic1: add pmic poweroff via sys-off handler

Use devm_register_sys_off_handler() that allows to register multiple
power-off handlers.
This will allow boards using the stpmic1 to power-off.

Signed-off-by: Sean Nyekjaer <[email protected]>
---
Changes since v1:
- Removed superfluous function

Changes since v2:
- Removed the devicetree option to turn the power-off functionality on and off.

drivers/mfd/stpmic1.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c
index 4c9b18d9dec8..9c7d1c3b8dfd 100644
--- a/drivers/mfd/stpmic1.c
+++ b/drivers/mfd/stpmic1.c
@@ -7,6 +7,7 @@
#include <linux/mfd/core.h>
#include <linux/mfd/stpmic1.h>
#include <linux/module.h>
+#include <linux/reboot.h>
#include <linux/of.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
@@ -117,6 +118,16 @@ static const struct regmap_irq_chip stpmic1_regmap_irq_chip = {
.num_irqs = ARRAY_SIZE(stpmic1_irqs),
};

+static int stpmic1_power_off(struct sys_off_data *data)
+{
+ struct stpmic1 *ddata = data->cb_data;
+
+ regmap_update_bits(ddata->regmap, MAIN_CR,
+ SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF);
+
+ return NOTIFY_DONE;
+}
+
static int stpmic1_probe(struct i2c_client *i2c)
{
struct stpmic1 *ddata;
@@ -159,6 +170,16 @@ static int stpmic1_probe(struct i2c_client *i2c)
return ret;
}

+ ret = devm_register_sys_off_handler(ddata->dev,
+ SYS_OFF_MODE_POWER_OFF,
+ SYS_OFF_PRIO_DEFAULT,
+ stpmic1_power_off,
+ ddata);
+ if (ret) {
+ dev_err(ddata->dev, "failed to register sys-off handler: %d\n", ret);
+ return ret;
+ }
+
return devm_of_platform_populate(dev);
}

--
2.40.0

2023-06-08 18:25:31

by Lee Jones

Subject: Re: [PATCH v3 2/2] mfd: stpmic1: add pmic poweroff via sys-off handler

On Fri, 02 Jun 2023, Sean Nyekjaer wrote:

> Use devm_register_sys_off_handler() that allows to register multiple
> power-off handlers.
> This will allow boards using the stpmic1 to power-off.
>
> Signed-off-by: Sean Nyekjaer <[email protected]>
> ---
> Changes since v1:
> - Removed superfluous function
>
> Changes since v2:
> - Removed the devicetree option to turn the power-off functionality on and off.
>
> drivers/mfd/stpmic1.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)

Applied, thanks

--
Lee Jones [李琼斯]