2023-06-08 22:50:58

by Chun-Tse Shao

[permalink] [raw]
Subject: [PATCH v1 1/3] KVM: arm64: Consistently use free_removed_table() for stage-2

From: Oliver Upton <[email protected]>

free_removed_table() is essential to the RCU-protected parallel walking
scheme, as behind the scenes the cleanup is deferred until an RCU grace
period. Nonetheless, the stage-2 unmap path calls put_page() directly,
which leads to table memory being freed inline with the table walk.

This is safe for the time being, as the stage-2 unmap walker is called
while holding the write lock. A future change to KVM will further relax
the locking mechanics around the stage-2 page tables to allow lock-free
walkers protected only by RCU. As such, switch to the RCU-safe mechanism
for freeing table memory.

Signed-off-by: Oliver Upton <[email protected]>
Signed-off-by: Chun-Tse Shao <[email protected]>
---
arch/arm64/kvm/hyp/pgtable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c
index 5282cb9ca4cf..cc1af0286755 100644
--- a/arch/arm64/kvm/hyp/pgtable.c
+++ b/arch/arm64/kvm/hyp/pgtable.c
@@ -1042,7 +1042,7 @@ static int stage2_unmap_walker(const struct kvm_pgtable_visit_ctx *ctx,
kvm_granule_size(ctx->level));

if (childp)
- mm_ops->put_page(childp);
+ mm_ops->free_removed_table(childp, ctx->level);

return 0;
}
--
2.41.0.162.gfafddb0af9-goog



2023-06-08 22:52:18

by Yu Zhao

[permalink] [raw]
Subject: Re: [PATCH v1 1/3] KVM: arm64: Consistently use free_removed_table() for stage-2

On Thu, Jun 8, 2023 at 4:06 PM Chun-Tse Shao <[email protected]> wrote:
>
> From: Oliver Upton <[email protected]>
>
> free_removed_table() is essential to the RCU-protected parallel walking
> scheme, as behind the scenes the cleanup is deferred until an RCU grace
> period. Nonetheless, the stage-2 unmap path calls put_page() directly,
> which leads to table memory being freed inline with the table walk.
>
> This is safe for the time being, as the stage-2 unmap walker is called
> while holding the write lock. A future change to KVM will further relax
> the locking mechanics around the stage-2 page tables to allow lock-free
> walkers protected only by RCU. As such, switch to the RCU-safe mechanism
> for freeing table memory.
>
> Signed-off-by: Oliver Upton <[email protected]>
> Signed-off-by: Chun-Tse Shao <[email protected]>

Acked-by: Yu Zhao <[email protected]>