2023-06-09 02:24:58

by Ammar Faizi

[permalink] [raw]
Subject: [PATCH liburing v1 0/2] Fixes for io_uring_for_each_cqe

Hi Jens,

Please consider taking these last-minute fixes for liburing-2.4
release. There are two patches in this series:

## 1. man/io_uring_for_each_cqe: Fix return value, title, and typo

- Fix the return value. io_uring_for_each_cqe() doesn't return an int.

- Fix the title, it was io_uring_wait_cqes(), it should be
io_uring_for_each_cqe().

- Fix typo: s/io_uring_for_each_cqes/io_uring_for_each_cqe/.

## 2. Explicitly tell it's a macro and add an example

Let the reader directly know that it's not a function, but a macro.
Also, give a simple example of its usage.

Signed-off-by: Alviro Iskandar Setiawan <[email protected]>
Signed-off-by: Ammar Faizi <[email protected]>
---

Ammar Faizi (2):
man/io_uring_for_each_cqe: Fix return value, title, and typo
man/io_uring_for_each_cqe: Explicitly tell it's a macro and add an example

man/io_uring_for_each_cqe.3 | 28 +++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)

base-commit: b4ee3108b93f7e4602430246236d14978abad085
--
Ammar Faizi



2023-06-09 03:07:06

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH liburing v1 0/2] Fixes for io_uring_for_each_cqe


On Fri, 09 Jun 2023 08:54:01 +0700, Ammar Faizi wrote:
> Please consider taking these last-minute fixes for liburing-2.4
> release. There are two patches in this series:
>
> ## 1. man/io_uring_for_each_cqe: Fix return value, title, and typo
>
> - Fix the return value. io_uring_for_each_cqe() doesn't return an int.
>
> [...]

Applied, thanks!

[1/2] man/io_uring_for_each_cqe: Fix return value, title, and typo
commit: c8d06ed9bcbf2ae294242f9caacecfa01bf138b2
[2/2] man/io_uring_for_each_cqe: Explicitly tell it's a macro and add an example
commit: 298c083d75ecde5a8833366167b3b6abff0c8d39

Best regards,
--
Jens Axboe




2023-06-09 03:07:06

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH liburing v1 0/2] Fixes for io_uring_for_each_cqe

On 6/8/23 7:54 PM, Ammar Faizi wrote:
> Hi Jens,
>
> Please consider taking these last-minute fixes for liburing-2.4
> release. There are two patches in this series:
>
> ## 1. man/io_uring_for_each_cqe: Fix return value, title, and typo
>
> - Fix the return value. io_uring_for_each_cqe() doesn't return an int.
>
> - Fix the title, it was io_uring_wait_cqes(), it should be
> io_uring_for_each_cqe().
>
> - Fix typo: s/io_uring_for_each_cqes/io_uring_for_each_cqe/.
>
> ## 2. Explicitly tell it's a macro and add an example
>
> Let the reader directly know that it's not a function, but a macro.
> Also, give a simple example of its usage.

Applied, even though not super critical for release. But this should
be it, I'll announce 2.4 tomorrow.

--
Jens Axboe