2023-05-30 07:04:26

by Franziska Näpelt

Subject: [PATCH v2] mips: Fix spacing issue

Fix some indentation issues and remove the following checkpatch issue:
- ERROR: need consistent spacing around '-' (ctx:WxV)

Co-Developed-by: Ladislav Michl <[email protected]>
Signed-off-by: Franziska Naepelt <[email protected]>
---
v2:
- Apply review remarks

arch/mips/sibyte/swarm/platform.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
index 484969db7713..339d77a0a08f 100644
--- a/arch/mips/sibyte/swarm/platform.c
+++ b/arch/mips/sibyte/swarm/platform.c
@@ -88,15 +88,15 @@ device_initcall(swarm_pata_init);
#define sb1250_dev_struct(num) \
static struct resource sb1250_res##num = { \
.name = "SB1250 MAC " __stringify(num), \
- .flags = IORESOURCE_MEM, \
- .start = A_MAC_CHANNEL_BASE(num), \
- .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
+ .flags = IORESOURCE_MEM, \
+ .start = A_MAC_CHANNEL_BASE(num), \
+ .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
};\
static struct platform_device sb1250_dev##num = { \
- .name = "sb1250-mac", \
- .id = num, \
- .resource = &sb1250_res##num, \
- .num_resources = 1, \
+ .name = "sb1250-mac", \
+ .id = num, \
+ .resource = &sb1250_res##num, \
+ .num_resources = 1, \
}

sb1250_dev_struct(0);

base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
--
2.39.2 (Apple Git-143)

2023-06-09 08:33:19

by Thomas Bogendoerfer

Subject: Re: [PATCH v2] mips: Fix spacing issue

On Tue, May 30, 2023 at 08:59:49AM +0200, Franziska Naepelt wrote:
> Fix some indentation issues and remove the following checkpatch issue:
> - ERROR: need consistent spacing around '-' (ctx:WxV)
>
> Co-Developed-by: Ladislav Michl <[email protected]>
> Signed-off-by: Franziska Naepelt <[email protected]>
> ---
> v2:
> - Apply review remarks
>
> arch/mips/sibyte/swarm/platform.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/mips/sibyte/swarm/platform.c b/arch/mips/sibyte/swarm/platform.c
> index 484969db7713..339d77a0a08f 100644
> --- a/arch/mips/sibyte/swarm/platform.c
> +++ b/arch/mips/sibyte/swarm/platform.c
> @@ -88,15 +88,15 @@ device_initcall(swarm_pata_init);
> #define sb1250_dev_struct(num) \
> static struct resource sb1250_res##num = { \
> .name = "SB1250 MAC " __stringify(num), \
> - .flags = IORESOURCE_MEM, \
> - .start = A_MAC_CHANNEL_BASE(num), \
> - .end = A_MAC_CHANNEL_BASE(num + 1) -1, \
> + .flags = IORESOURCE_MEM, \
> + .start = A_MAC_CHANNEL_BASE(num), \
> + .end = A_MAC_CHANNEL_BASE(num + 1) - 1, \
> };\
> static struct platform_device sb1250_dev##num = { \
> - .name = "sb1250-mac", \
> - .id = num, \
> - .resource = &sb1250_res##num, \
> - .num_resources = 1, \
> + .name = "sb1250-mac", \
> + .id = num, \
> + .resource = &sb1250_res##num, \
> + .num_resources = 1, \
> }
>
> sb1250_dev_struct(0);
>
> base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
> --
> 2.39.2 (Apple Git-143)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]