2023-06-06 21:26:36

by Liviu Dudau

[permalink] [raw]
Subject: [PATCH v4 0/2] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board

Add device tree and bindings for the TP-Link HC220 G5 v1 wireless AP,
a consumer product from TP-Link based on MT7621.

Changes since v3:
- Turns out that adding sub-nodes to the pcie invites more warnings from
dtbs_check so we're dropping those
- Running dtbs_check made me realise that I need to re-order the patches
so that the bindings are introduced first. Hence the major change in v4
is the re-ordering of patches
- Renamed the LEDs nodes to match the schema.

Changes since v2:
- Remove WIP nodes for NAND flash that accidentally got included in v2
- Fix commit message with the actual 5GHz WiFi chip name
- Remove gmac and mdio nodes from device tree as defaults are sufficient
- Added sub-nodes under pcie for each of the WiFi chip with appropriate
compatible string.
- Collect Acks received for the device tree bindings patch

Changes since v1:
- Changed compatible for the board to "tplink,hc220-g5-v1"
- Updated the DSA switch nodes to better reflect actual usage.
- Disabled the fixed-link in gmac1
- Added device tree bindings in Documentation/

v3: https://lore.kernel.org/linux-mips/[email protected]/
v2: https://lore.kernel.org/linux-mips/[email protected]/
v1: https://lore.kernel.org/linux-mips/[email protected]/

Liviu Dudau (2):
dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board
mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board

.../devicetree/bindings/mips/ralink.yaml | 1 +
arch/mips/boot/dts/ralink/Makefile | 3 +-
.../dts/ralink/mt7621-tplink-hc220-g5-v1.dts | 84 +++++++++++++++++++
3 files changed, 87 insertions(+), 1 deletion(-)
create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dts

--
2.40.1



2023-06-06 21:32:37

by Liviu Dudau

[permalink] [raw]
Subject: [PATCH v4 1/2] dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board

Add bindings for the compatible string used for the TP-Link's
HC220 G5 V1 board, a wireless AP based on MT7621.

Signed-off-by: Liviu Dudau <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Acked-by: Sergio Paracuellos <[email protected]>
---
Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
index 704b5b5951271..53c1f66353770 100644
--- a/Documentation/devicetree/bindings/mips/ralink.yaml
+++ b/Documentation/devicetree/bindings/mips/ralink.yaml
@@ -80,6 +80,7 @@ properties:
- enum:
- gnubee,gb-pc1
- gnubee,gb-pc2
+ - tplink,hc220-g5-v1
- const: mediatek,mt7621-soc

additionalProperties: true
--
2.40.1


2023-06-09 09:31:05

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board

On Tue, Jun 06, 2023 at 10:15:58PM +0100, Liviu Dudau wrote:
> Add device tree and bindings for the TP-Link HC220 G5 v1 wireless AP,
> a consumer product from TP-Link based on MT7621.
>
> Changes since v3:
> - Turns out that adding sub-nodes to the pcie invites more warnings from
> dtbs_check so we're dropping those
> - Running dtbs_check made me realise that I need to re-order the patches
> so that the bindings are introduced first. Hence the major change in v4
> is the re-ordering of patches
> - Renamed the LEDs nodes to match the schema.
>
> Changes since v2:
> - Remove WIP nodes for NAND flash that accidentally got included in v2
> - Fix commit message with the actual 5GHz WiFi chip name
> - Remove gmac and mdio nodes from device tree as defaults are sufficient
> - Added sub-nodes under pcie for each of the WiFi chip with appropriate
> compatible string.
> - Collect Acks received for the device tree bindings patch
>
> Changes since v1:
> - Changed compatible for the board to "tplink,hc220-g5-v1"
> - Updated the DSA switch nodes to better reflect actual usage.
> - Disabled the fixed-link in gmac1
> - Added device tree bindings in Documentation/
>
> v3: https://lore.kernel.org/linux-mips/[email protected]/
> v2: https://lore.kernel.org/linux-mips/[email protected]/
> v1: https://lore.kernel.org/linux-mips/[email protected]/
>
> Liviu Dudau (2):
> dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board
> mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board
>
> .../devicetree/bindings/mips/ralink.yaml | 1 +
> arch/mips/boot/dts/ralink/Makefile | 3 +-
> .../dts/ralink/mt7621-tplink-hc220-g5-v1.dts | 84 +++++++++++++++++++
> 3 files changed, 87 insertions(+), 1 deletion(-)
> create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dts
>
> --
> 2.40.1

series applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]