2023-06-09 08:55:41

by Yang Li

Subject: [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c

./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464
Signed-off-by: Yang Li <[email protected]>
---
tools/net/ynl/generated/devlink-user.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/net/ynl/generated/devlink-user.c b/tools/net/ynl/generated/devlink-user.c
index c3204e20b971..18157afd7c73 100644
--- a/tools/net/ynl/generated/devlink-user.c
+++ b/tools/net/ynl/generated/devlink-user.c
@@ -8,7 +8,6 @@
#include "ynl.h"
#include <linux/devlink.h>

-#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <libmnl/libmnl.h>
--
2.20.1.7.g153144c

2023-06-09 08:55:47

by Yang Li

Subject: [PATCH net-next 1/3] net: hv_netvsc: Remove duplicated include in rndis_filter.c

./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5462
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/hyperv/rndis_filter.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index af95947a87c5..ecc2128ca9b7 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -21,7 +21,6 @@
#include <linux/rtnetlink.h>
#include <linux/ucs2_string.h>
#include <linux/string.h>
-#include <linux/slab.h>

#include "hyperv_net.h"
#include "netvsc_trace.h"
--
2.20.1.7.g153144c

2023-06-09 09:01:07

by Yang Li

Subject: [PATCH net-next 2/3] tools: ynl: Remove duplicated include in handshake-user.c

./tools/net/ynl/generated/handshake-user.c: stdlib.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464
Signed-off-by: Yang Li <[email protected]>
---
tools/net/ynl/generated/handshake-user.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/net/ynl/generated/handshake-user.c b/tools/net/ynl/generated/handshake-user.c
index fe99c4ef7373..7a1f0364b88f 100644
--- a/tools/net/ynl/generated/handshake-user.c
+++ b/tools/net/ynl/generated/handshake-user.c
@@ -8,7 +8,6 @@
#include "ynl.h"
#include <linux/handshake.h>

-#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <libmnl/libmnl.h>
--
2.20.1.7.g153144c

2023-06-09 10:46:38

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Fri, 9 Jun 2023 16:52:47 +0800 you wrote:
> ./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464
> Signed-off-by: Yang Li <[email protected]>
> ---
> tools/net/ynl/generated/devlink-user.c | 1 -
> 1 file changed, 1 deletion(-)

Here is the summary with links:
- [net-next,3/3] tools: ynl: Remove duplicated include in devlink-user.c
(no matching commit)
- [net-next,2/3] tools: ynl: Remove duplicated include in handshake-user.c
https://git.kernel.org/netdev/net-next/c/e7c5433c5aaa
- [net-next,1/3] net: hv_netvsc: Remove duplicated include in rndis_filter.c
(no matching commit)

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2023-06-09 11:48:16

by Jiri Pirko

Subject: Re: [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c

Fri, Jun 09, 2023 at 10:52:47AM CEST, [email protected] wrote:
>./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.
>
>Reported-by: Abaci Robot <[email protected]>
>Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464
>Signed-off-by: Yang Li <[email protected]>
>---
> tools/net/ynl/generated/devlink-user.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/tools/net/ynl/generated/devlink-user.c b/tools/net/ynl/generated/devlink-user.c
>index c3204e20b971..18157afd7c73 100644
>--- a/tools/net/ynl/generated/devlink-user.c
>+++ b/tools/net/ynl/generated/devlink-user.c

You are patching generated file, as the path suggests.
See what the file header says:
/* Do not edit directly, auto-generated from: */
/* Documentation/netlink/specs/devlink.yaml */


>@@ -8,7 +8,6 @@
> #include "ynl.h"
> #include <linux/devlink.h>
>
>-#include <stdlib.h>
> #include <stdio.h>
> #include <string.h>
> #include <libmnl/libmnl.h>
>--
>2.20.1.7.g153144c
>
>

2023-06-09 18:27:35

by Jakub Kicinski

Subject: Re: [PATCH net-next 3/3] tools: ynl: Remove duplicated include in devlink-user.c

On Fri, 9 Jun 2023 13:38:21 +0200 Jiri Pirko wrote:
> You are patching generated file, as the path suggests.
> See what the file header says:
> /* Do not edit directly, auto-generated from: */
> /* Documentation/netlink/specs/devlink.yaml */

And the full fix is already on the list :(
https://lore.kernel.org/all/[email protected]/
Reverted...