2023-06-10 10:40:29

by Yue Haibing

Subject: [PATCH -next] mm: Remove unused vma_init_lock()

commit c7f8f31c00d1 ("mm: separate vma->lock from vm_area_struct")
left this behind.

Signed-off-by: YueHaibing <[email protected]>
---
include/linux/mm.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 0db09639dd2d..1970772c07bb 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -725,7 +725,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm,

#else /* CONFIG_PER_VMA_LOCK */

-static inline void vma_init_lock(struct vm_area_struct *vma) {}
static inline bool vma_start_read(struct vm_area_struct *vma)
{ return false; }
static inline void vma_end_read(struct vm_area_struct *vma) {}
--
2.34.1

2023-06-12 09:33:08

by David Hildenbrand

Subject: Re: [PATCH -next] mm: Remove unused vma_init_lock()

On 10.06.23 12:19, YueHaibing wrote:
> commit c7f8f31c00d1 ("mm: separate vma->lock from vm_area_struct")
> left this behind.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> include/linux/mm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 0db09639dd2d..1970772c07bb 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -725,7 +725,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm,
>
> #else /* CONFIG_PER_VMA_LOCK */
>
> -static inline void vma_init_lock(struct vm_area_struct *vma) {}
> static inline bool vma_start_read(struct vm_area_struct *vma)
> { return false; }
> static inline void vma_end_read(struct vm_area_struct *vma) {}

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb