2023-06-10 12:31:53

by Shreeya Patel

Subject: [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning

Fix the dtbs_check warning for 'oneOf' condition failure.

DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb
/home/shreeya/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb:
saradc@fec10000: compatible: 'oneOf' conditional failed,
one must be fixed:
['rockchip,rk3588-saradc'] is too short
'rockchip,saradc' was expected
'rockchip,rk3066-tsadc' was expected
'rockchip,rk3399-saradc' was expected

Fixes: 2daf2ae9793d ("dt-bindings: iio: adc: Add rockchip,rk3588-saradc string")
Signed-off-by: Shreeya Patel <[email protected]>
---
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index 11c27ea451c8..aa24b841393c 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -15,13 +15,13 @@ properties:
- const: rockchip,saradc
- const: rockchip,rk3066-tsadc
- const: rockchip,rk3399-saradc
+ - const: rockchip,rk3588-saradc
- items:
- enum:
- rockchip,px30-saradc
- rockchip,rk3308-saradc
- rockchip,rk3328-saradc
- rockchip,rk3568-saradc
- - rockchip,rk3588-saradc
- rockchip,rv1108-saradc
- rockchip,rv1126-saradc
- const: rockchip,rk3399-saradc
--
2.30.2

2023-06-10 13:11:46

by Heiko Stuebner

Subject: Re: [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning

Am Samstag, 10. Juni 2023, 14:22:00 CEST schrieb Shreeya Patel:
> Fix the dtbs_check warning for 'oneOf' condition failure.
>
> DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb
> /home/shreeya/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb:
> saradc@fec10000: compatible: 'oneOf' conditional failed,
> one must be fixed:
> ['rockchip,rk3588-saradc'] is too short
> 'rockchip,saradc' was expected
> 'rockchip,rk3066-tsadc' was expected
> 'rockchip,rk3399-saradc' was expected
>

Nit: the commit message could explain that the rk3588 in fact isn't
compatible with the rk3399-saradc variant.

Otherwise I checked the implementation, so
Reviewed-by: Heiko Stuebner <[email protected]>

> Fixes: 2daf2ae9793d ("dt-bindings: iio: adc: Add rockchip,rk3588-saradc string")
> Signed-off-by: Shreeya Patel <[email protected]>
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index 11c27ea451c8..aa24b841393c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -15,13 +15,13 @@ properties:
> - const: rockchip,saradc
> - const: rockchip,rk3066-tsadc
> - const: rockchip,rk3399-saradc
> + - const: rockchip,rk3588-saradc
> - items:
> - enum:
> - rockchip,px30-saradc
> - rockchip,rk3308-saradc
> - rockchip,rk3328-saradc
> - rockchip,rk3568-saradc
> - - rockchip,rk3588-saradc
> - rockchip,rv1108-saradc
> - rockchip,rv1126-saradc
> - const: rockchip,rk3399-saradc
>