2023-06-09 14:43:17

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: i3c: silvaco,i3c-master: fix missing schema restriction

Each device schema must end with unevaluatedProperties: false, if it
references other common schema. Otherwise it would allow any properties
to be listed.

Fixes: b8b0446f1f1a ("dt-bindings: i3c: Describe Silvaco master binding")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
index 543b177f8610..133855f11b4f 100644
--- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
+++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
@@ -44,7 +44,7 @@ required:
- clock-names
- clocks

-additionalProperties: true
+unevaluatedProperties: false

examples:
- |
--
2.34.1



2023-06-09 22:54:22

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i3c: silvaco,i3c-master: fix missing schema restriction


On Fri, 09 Jun 2023 16:11:07 +0200, Krzysztof Kozlowski wrote:
> Each device schema must end with unevaluatedProperties: false, if it
> references other common schema. Otherwise it would allow any properties
> to be listed.
>
> Fixes: b8b0446f1f1a ("dt-bindings: i3c: Describe Silvaco master binding")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!


2023-06-11 16:04:52

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: i3c: silvaco,i3c-master: fix missing schema restriction

On 09/06/2023 16:14:03-0600, Rob Herring wrote:
>
> On Fri, 09 Jun 2023 16:11:07 +0200, Krzysztof Kozlowski wrote:
> > Each device schema must end with unevaluatedProperties: false, if it
> > references other common schema. Otherwise it would allow any properties
> > to be listed.
> >
> > Fixes: b8b0446f1f1a ("dt-bindings: i3c: Describe Silvaco master binding")
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Applied, thanks!

As you took this one, I assume you are going to take the previous patch.

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com